[l3][port_forwarding] internal/external port should not allow 0

[LIU Yulong]

ENV: devstack master

Floating IP port forwarding internal or external port number should not allow 0, otherwise you will get some ValueError exception in neutron server.

Step to reproduce:
1. create router with connected privated subnet and public gateway.
2. create VM to the private subnet
3. create floating IP
4. create port forwarding with internal or external port number 0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/613562

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/614081

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/614394

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613562
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=8dc31ec5f2db6e6ff5b2b4d4a27c239de5e12cfb
Submitter: Zuul
Branch: master

commit 8dc31ec5f2db6e6ff5b2b4d4a27c239de5e12cfb
Author: LIU Yulong <email address hidden>
Date: Fri Oct 26 19:40:15 2018 +0800

    Disable port number 0 for floating IP port_forwarding

    Floating IP port forwarding internal or external port number should
    not allow 0, otherwise you will get some ValueError exception in
    neutron server.

    Directly modify the floating-ip-port-forwarding extension to change
    the external_port and internal_port minimum value.

    Change-Id: Icb177932f6cf1262757b29cb9b997321704616b7
    Closes-Bug: #1799150

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614081
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c1837812318eb732076a6c928c8903094ec9d6e3
Submitter: Zuul
Branch: master

commit c1837812318eb732076a6c928c8903094ec9d6e3
Author: LIU Yulong <email address hidden>
Date: Tue Oct 30 12:30:24 2018 +0800

    Add test cases to verify port number 0 for port_forwaring

    Floating IP port forwarding internal or external port number should
    not allow 0, otherwise you will get some ValueError exception in
    neutron server.

    Change-Id: I8bf8ed6f9c4b937743f8c0f998ee897e3af17459
    Closes-Bug: #1799150

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-lib 1.20.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614394
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c8cb1454afcb65d1ecbd2716888edd3819cdec5b
Submitter: Zuul
Branch: master

commit c8cb1454afcb65d1ecbd2716888edd3819cdec5b
Author: LIU Yulong <email address hidden>
Date: Tue Oct 30 18:42:08 2018 +0800

    Add test cases for port number 0 for port_forwarding

    Depends-On: https://review.openstack.org/#/c/616030/
    Depends-On: https://review.openstack.org/#/c/613562/

    Closes-Bug: #1799150
    Change-Id: Iae80e59e3472cfccdf28ff29ba2f630781258ebc

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.