metadata agent can't use ipv6 addresses for nova_metadata_host

[Antonio Ojea]

It's a known issue that metadata services don't work for ipv6-only tenant networks [1]

However, it can be possible that operators want to use ipv4 and ipv6 tenant networks with an underlay ipv6 infra.

This doesn't work as you can see in the devstack failure [2] because the metadata agent, when building the request, doesn't check if the nova_metadata_host is an ipv6 address to add the corresponding square brackets [3].

[1] https://bugs.launchpad.net/neutron/+bug/1460177
[2] http://logs.openstack.org/68/608168/5/check/tempest-full-py3/d2321db/controller/logs/screen-q-meta.txt.gz#_Oct_07_18_00_37_770322
[3] https://github.com/openstack/neutron/blob/3e579256a36e66960495da2f303b5a6e37f644a6/neutron/agent/metadata/agent.py#L180

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/608468

[Antonio Ojea (aojea)]

Tests results are passing with the patch proposed https://review.openstack.org/#/c/608168/ , job tempest-full-py3 deploys a devstack environment with IPv6 as underlay and ::1 as nova_metadata_host.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/608468
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=85588ad38e3a08137f4f7b4be98ce271064eb2f0
Submitter: Zuul
Branch: master

commit 85588ad38e3a08137f4f7b4be98ce271064eb2f0
Author: aojeagarcia <email address hidden>
Date: Sun Oct 7 23:17:08 2018 +0200

    Allow Ipv6 addresses for nova_metadata_host

    Current logic didn't check if the nova_metadata_host is an IPv6 address
    causing the proxy request to fail with an exception because the url is
    not valid.

    This patchs check if the nova_metadata_host is an IPv6 address and
    create a valid url enclosing the IPv6 address with brackets

    Closes-Bug: #1796593

    Change-Id: Ibfebffcec2c8860237a1f151084de978a7863bd8
    Signed-off-by: aojeagarcia <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/610190

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/610191

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/610192

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/610190
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=198437297352aa1e9122d9315184baac443868a1
Submitter: Zuul
Branch: stable/rocky

commit 198437297352aa1e9122d9315184baac443868a1
Author: aojeagarcia <email address hidden>
Date: Sun Oct 7 23:17:08 2018 +0200

    Allow Ipv6 addresses for nova_metadata_host

    Current logic didn't check if the nova_metadata_host is an IPv6 address
    causing the proxy request to fail with an exception because the url is
    not valid.

    This patchs check if the nova_metadata_host is an IPv6 address and
    create a valid url enclosing the IPv6 address with brackets

    Closes-Bug: #1796593

    Change-Id: Ibfebffcec2c8860237a1f151084de978a7863bd8
    Signed-off-by: aojeagarcia <email address hidden>
    (cherry picked from commit 85588ad38e3a08137f4f7b4be98ce271064eb2f0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/610191
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fa9685ada1d30161851b79459b1255d24f88cd64
Submitter: Zuul
Branch: stable/queens

commit fa9685ada1d30161851b79459b1255d24f88cd64
Author: aojeagarcia <email address hidden>
Date: Sun Oct 7 23:17:08 2018 +0200

    Allow Ipv6 addresses for nova_metadata_host

    Current logic didn't check if the nova_metadata_host is an IPv6 address
    causing the proxy request to fail with an exception because the url is
    not valid.

    This patchs check if the nova_metadata_host is an IPv6 address and
    create a valid url enclosing the IPv6 address with brackets

    Closes-Bug: #1796593

    Change-Id: Ibfebffcec2c8860237a1f151084de978a7863bd8
    Signed-off-by: aojeagarcia <email address hidden>
    (cherry picked from commit 85588ad38e3a08137f4f7b4be98ce271064eb2f0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/610192
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2fba9f42b92bbe7ec24a5549251daa8af1049578
Submitter: Zuul
Branch: stable/pike

commit 2fba9f42b92bbe7ec24a5549251daa8af1049578
Author: aojeagarcia <email address hidden>
Date: Sun Oct 7 23:17:08 2018 +0200

    Allow Ipv6 addresses for nova_metadata_host

    Current logic didn't check if the nova_metadata_host is an IPv6 address
    causing the proxy request to fail with an exception because the url is
    not valid.

    This patchs check if the nova_metadata_host is an IPv6 address and
    create a valid url enclosing the IPv6 address with brackets

    Closes-Bug: #1796593

    Change-Id: Ibfebffcec2c8860237a1f151084de978a7863bd8
    Signed-off-by: aojeagarcia <email address hidden>
    (cherry picked from commit 85588ad38e3a08137f4f7b4be98ce271064eb2f0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.7 release.