neutron

PlacementAPIClient.update_resource_class wrong client call, missing argument

Bug #1794545 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rodolfo Alonso

Bug Description

"PlacementAPIClient.update_resource_class" is calling Placement client "put" method with a missing argument, "data". In this call, "data" should be None [1], but it's a positional argument and must be passed.

[1] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L41

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/605455

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/605455
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=691cd287ba7457aa4fdae100620f2ca8f11400ed
Submitter: Zuul
Branch: master

commit 691cd287ba7457aa4fdae100620f2ca8f11400ed
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 26 16:11:55 2018 +0100

    PlacementAPIClient.update_resource_class client call missing argument

    "PlacementAPIClient.update_resource_class" is calling Placement client
    "put" method with a missing argument, "data". In this call, "data"
    should be None [1], but it's a positional argument and must be passed.

    [1] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L41

    Change-Id: Iedcad7c81a913923506bed2762b60b094f2d601d
    Closes-Bug: #1794545

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lib 1.20.0

This issue was fixed in the openstack/neutron-lib 1.20.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.