pep8 tests failing on "./tools/coding-checks.sh --pylint"

Bug #1791178 reported by Slawek Kaplonski
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Brian Haley

Bug Description

Example of failure: http://logs.openstack.org/37/382037/73/gate/openstack-tox-pep8/7f200e6/job-output.txt.gz#_2018-09-06_17_48_34_700485

Paste version of the above error message: http://paste.openstack.org/show/729981/

It is probably because of new eventlet = 0.24.0 used now.

Changed in neutron:
assignee: nobody → Slawek Kaplonski (slaweq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/600565

Changed in neutron:
status: Confirmed → In Progress
Changed in neutron:
assignee: Slawek Kaplonski (slaweq) → Brian Haley (brian-haley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/602097

Akihiro Motoki (amotoki)
description: updated
Changed in neutron:
assignee: Brian Haley (brian-haley) → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/600565
Reason: Better approach proposed in https://review.openstack.org/#/c/602097/

Changed in neutron:
assignee: Akihiro Motoki (amotoki) → Brian Haley (brian-haley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/602688

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Brian Haley (<email address hidden>) on branch: master
Review: https://review.openstack.org/602688

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/602097
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=db7e19d2ba3fcde0510be0094a4851178fae578b
Submitter: Zuul
Branch: master

commit db7e19d2ba3fcde0510be0094a4851178fae578b
Author: Brian Haley <email address hidden>
Date: Wed Sep 12 10:54:47 2018 -0600

    Fix pylint warning with eventlet > 0.22.0

    When eventlet was bumped up to 0.24.1 in upper-constraints [1]
    it started generating a pylint warning, since neutron has
    support for older versions such as 0.22.0 that take a different
    number of arguments. Just silence the warning.

    Also, in order to get this through the gate, the
    neutron-grenade-dvr-multinode check job is being temporarily
    set to non-voting and removed from the gate. That change
    should be reverted as soon as we fix bug 1791989.

    [1] https://review.openstack.org/#/c/589382/

    Change-Id: I169ecb6f33b670c5469919214a32645cd9eda206
    Closes-Bug: #1791178
    Related-Bug: #1791989

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/603041

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.openstack.org/603041
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1c1bb732021a318143a4a5eef461fdbe2ccac42e
Submitter: Zuul
Branch: stable/rocky

commit 1c1bb732021a318143a4a5eef461fdbe2ccac42e
Author: Brian Haley <email address hidden>
Date: Wed Sep 12 10:54:47 2018 -0600

    Fix pylint warning with eventlet > 0.22.0

    When eventlet was bumped up to 0.24.1 in upper-constraints [1]
    it started generating a pylint warning, since neutron has
    support for older versions such as 0.22.0 that take a different
    number of arguments. Just silence the warning.

    [1] https://review.openstack.org/#/c/589382/

    This warning can also happen on 0.20 packages with backport fixes

    Change-Id: I169ecb6f33b670c5469919214a32645cd9eda206
    Closes-Bug: #1791178
    (cherry picked from commit db7e19d2ba3fcde0510be0094a4851178fae578b)

tags: added: in-stable-rocky
tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.2

This issue was fixed in the openstack/neutron 13.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b1

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.