neutron bridge name is not always set for ml2/ovs

[sean mooney]

* Summary: neutron bridge name is not always set for ml2/ovs

* High level description: to enable live migration between different ml2
drivers utilizing multiple port bindings nova cannot assume the bridge name of
the destination host when generating the vm domain(e.g. libvirt xml)
to this end the ovs bridge name which is set when using trunk ports
also needs to be set in the general case.

* Expected output:
when a port is bound by the ml2/ovs mech driver the bridge
name is set in the vif binding-details.

* Actual output:
because the bridge name is not in the general case when you live migrate
from linux bridge to ovs the vm is attach to a new ovs bridge using the linux
bridge, bride name of the source node node instead attaching the vm interface
to the br-int bridge. as a result while the migration is successful
the vm will have no network connectivity as this new bridge is not connect to the
br-int via a patch port pair.

* Version:
  ** OpenStack version master/Rocky RC1
  ** Centos 7.5
  ** DevStack

* Environment: multinode default devstack install.

* Perceived severity: low( it is a trival fix but it does prevent migrating form lb to ovs hosts)

Click on extra options for the following:

[Hongbin Lu (hongbin.lu)]

Confirmed that this bug is reproducible on master. Boot a VM in a linuxbridge node, migrate the VM to an OVS node, the VM will lose network connectivity.

[Hongbin Lu (hongbin.lu)]

From neutron's point of view, this seems like a feature enhancement (because the request is to let neutron to provide more information to assist nova to bind the migrating port). I am going to mark this bug as RFE and leave it to neutron driver team for triaging.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/596896

[Brian Haley (brian-haley)]

Added rfe-triaged so it gets on the drivers list, forgot to do that yesterday

[Miguel Lavalle (minsel)]

We discussed this after the drivers meeting today and decided to handle it a a regular bug

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/596896
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=995744c576503b1de90c922dbecf690ad49f244f
Submitter: Zuul
Branch: master

commit 995744c576503b1de90c922dbecf690ad49f244f
Author: Sean Mooney <email address hidden>
Date: Mon Aug 27 18:30:53 2018 +0100

    Always set ovs bridge name in vif:binding-details

    - This change updates _set_bridge_name to set
      the bridge name field in the vif binding details.
    - This change adds the integration_bridge name
      to the agent configuration report.

    Change-Id: I454efcb226745c585935d5bd1b3d378f69a55ca2
    Closes-Bug: #1788009

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/700878

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/700883

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/700883
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d286f9ea1ed4f6ed90e557f9584b553ef4272e96
Submitter: Zuul
Branch: stable/rocky

commit d286f9ea1ed4f6ed90e557f9584b553ef4272e96
Author: zhangyuhe <email address hidden>
Date: Tue Aug 28 01:30:53 2018 +0800

    Always set ovs bridge name in vif:binding-details

    - This change updates _set_bridge_name to set
      the bridge name field in the vif binding details.
    - This change adds the integration_bridge name
      to the agent configuration report.

    Closes-Bug: #1788009
    Closes-Bug: #1856152

    (cherry picked from commit 995744c576503b1de90c922dbecf690ad49f244f)
    Change-Id: I454efcb226745c585935d5bd1b3d378f69a55ca2

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/700878
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f95b473a9c90244e21bc86ef6af70f4fe8dbda5e
Submitter: Zuul
Branch: stable/queens

commit f95b473a9c90244e21bc86ef6af70f4fe8dbda5e
Author: zhangyuhe <email address hidden>
Date: Tue Aug 28 01:30:53 2018 +0800

    Always set ovs bridge name in vif:binding-details

    - This change updates _set_bridge_name to set
      the bridge name field in the vif binding details.
    - This change adds the integration_bridge name
      to the agent configuration report.

    Closes-Bug: #1788009
    Closes-Bug: #1856152

    (cherry picked from commit 995744c576503b1de90c922dbecf690ad49f244f)
    Change-Id: I454efcb226745c585935d5bd1b3d378f69a55ca2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron queens-eol release.