test_internal_dns.InternalDNSTest fails even though dns-integration extension isn't loaded

Bug #1785656 reported by Mike Kolesnik on 2018-08-06
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-odl
Critical
Manjeet Singh Bhatia
neutron
High
Manjeet Singh Bhatia

Bug Description

We're seeing this on the Networking-ODL CI [1].

The test neutron_tempest_plugin.scenario.test_internal_dns.InternalDNSTest is being executed even though there's a decorator to prevent it from running [2]

Either the checker isn't working or something is missing, since other DNS tests are being skipped automatically due to the extension not being loaded.

[1] http://logs.openstack.org/91/584591/5/check/networking-odl-tempest-oxygen/df17c02/
[2] http://git.openstack.org/cgit/openstack/neutron-tempest-plugin/tree/neutron_tempest_plugin/scenario/test_internal_dns.py#n28

Changed in neutron:
status: New → Confirmed
Mike Kolesnik (mkolesni) on 2018-08-06
Changed in networking-odl:
importance: Undecided → Critical
status: New → Confirmed
Changed in neutron:
importance: Undecided → High
Brian Haley (brian-haley) wrote :

From looking at the logs for the other dns test file:

http://logs.openstack.org/91/584591/5/check/networking-odl-tempest-oxygen/df17c02/job-output.txt.gz#_2018-08-06_10_16_43_344180

setUpClass (neutron_tempest_plugin.scenario.test_dns_integration.DNSIntegrationTests) ... SKIPPED: Designate support is required

Looks like this dns test class needs to copy/paste skip_checks() etc from neutron_tempest_plugin/scenario/test_dns_integration.py:DNSIntegrationTests

Miguel Lavalle (minsel) wrote :
Changed in neutron:
assignee: nobody → Manjeet Singh Bhatia (manjeet-s-bhatia)
Miguel Lavalle (minsel) wrote :
Changed in neutron:
status: Confirmed → In Progress

both fixes may work, ! we can verify both independently and landing both would be safer.

Change abandoned by Mike Kolesnik (<email address hidden>) on branch: master
Review: https://review.openstack.org/589202
Reason: Abandoned in favor of https://review.openstack.org/#/c/589247

Thanks Manjeet!

Reviewed: https://review.openstack.org/589247
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=ff3bb29bc5b482639b721a93921149eb0c2baa2c
Submitter: Zuul
Branch: master

commit ff3bb29bc5b482639b721a93921149eb0c2baa2c
Author: Manjeet Singh Bhatia <email address hidden>
Date: Mon Aug 6 18:00:37 2018 +0000

    Remove dns-integration from NETWORK_API_EXTENSIONS

    As of now DNS-integration is not supported by networking-odl,
    which cause failure of tempest test and require_ext decorator is
    not very smart enough to figure out if extension is actually
    enabled or not, it just reads the tempest conf and decides regardless
    of actual environment. This patch removes dns-integration from
    tempest-conf.

    Change-Id: If600cc0989ba16606291e83bcc029537d57e5017
    Related-Bug: #1785656

Mike Kolesnik (mkolesni) on 2018-08-07
Changed in networking-odl:
status: Confirmed → Fix Committed
assignee: nobody → Manjeet Singh Bhatia (manjeet-s-bhatia)
Miguel Lavalle (minsel) on 2019-03-25
Changed in neutron:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers