Neutron ovs agent logs flooded with KeyErrors

Bug #1783556 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Lucian Petrut

Bug Description

The Neutron OVS agent logs can get flooded with KeyErrors as the '_get_port_info' method skips the added/removed dict items if no ports have been added/removed, which are expected to be present, even if those are just empty sets.

Trace: http://paste.openstack.org/raw/726614/

tags: added: ovs
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/585742

Changed in neutron:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/585742
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=da5b13df2b2a8171f60311414250671820390738
Submitter: Zuul
Branch: master

commit da5b13df2b2a8171f60311414250671820390738
Author: Lucian Petrut <email address hidden>
Date: Wed Jul 25 16:05:04 2018 +0300

    Trivial: avoid KeyError while processing ports

    The Neutron OVS agent logs can get flooded with KeyErrors as the
    '_get_port_info' method skips the added/removed dict items if no
    ports have been added/removed, which are expected to be present,
    even if those are just empty sets.

    This change ensures that those port info dict fields are always set.

    Closes-Bug: #1783556

    Change-Id: I9e5325aa2d8525231353ba451e8ea895be51b1ca

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential
tags: added: neutron-easy-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/592997

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/592998

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/592999

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/593000

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.openstack.org/592997
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eec374c4d8cde209803fd7ee85f2850a650d1e28
Submitter: Zuul
Branch: stable/rocky

commit eec374c4d8cde209803fd7ee85f2850a650d1e28
Author: Lucian Petrut <email address hidden>
Date: Wed Jul 25 16:05:04 2018 +0300

    Trivial: avoid KeyError while processing ports

    The Neutron OVS agent logs can get flooded with KeyErrors as the
    '_get_port_info' method skips the added/removed dict items if no
    ports have been added/removed, which are expected to be present,
    even if those are just empty sets.

    This change ensures that those port info dict fields are always set.

    Closes-Bug: #1783556

    Change-Id: I9e5325aa2d8525231353ba451e8ea895be51b1ca
    (cherry picked from commit da5b13df2b2a8171f60311414250671820390738)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.0.0rc2

This issue was fixed in the openstack/neutron 13.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/queens)

Reviewed: https://review.openstack.org/592998
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2652100446a5614a1b2e6368846737966a84d1eb
Submitter: Zuul
Branch: stable/queens

commit 2652100446a5614a1b2e6368846737966a84d1eb
Author: Lucian Petrut <email address hidden>
Date: Wed Jul 25 16:05:04 2018 +0300

    Trivial: avoid KeyError while processing ports

    The Neutron OVS agent logs can get flooded with KeyErrors as the
    '_get_port_info' method skips the added/removed dict items if no
    ports have been added/removed, which are expected to be present,
    even if those are just empty sets.

    This change ensures that those port info dict fields are always set.

    Closes-Bug: #1783556

    Change-Id: I9e5325aa2d8525231353ba451e8ea895be51b1ca
    (cherry picked from commit da5b13df2b2a8171f60311414250671820390738)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.openstack.org/592999
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=64a9d41d74f6cf9fe9f9181a5f7980437626340d
Submitter: Zuul
Branch: stable/pike

commit 64a9d41d74f6cf9fe9f9181a5f7980437626340d
Author: Lucian Petrut <email address hidden>
Date: Wed Jul 25 16:05:04 2018 +0300

    Trivial: avoid KeyError while processing ports

    The Neutron OVS agent logs can get flooded with KeyErrors as the
    '_get_port_info' method skips the added/removed dict items if no
    ports have been added/removed, which are expected to be present,
    even if those are just empty sets.

    This change ensures that those port info dict fields are always set.

    Closes-Bug: #1783556

    Change-Id: I9e5325aa2d8525231353ba451e8ea895be51b1ca
    (cherry picked from commit da5b13df2b2a8171f60311414250671820390738)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/593000
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e60a510d85de9a71b1885bc56d2d432b649a73a6
Submitter: Zuul
Branch: stable/ocata

commit e60a510d85de9a71b1885bc56d2d432b649a73a6
Author: Lucian Petrut <email address hidden>
Date: Wed Jul 25 16:05:04 2018 +0300

    Trivial: avoid KeyError while processing ports

    The Neutron OVS agent logs can get flooded with KeyErrors as the
    '_get_port_info' method skips the added/removed dict items if no
    ports have been added/removed, which are expected to be present,
    even if those are just empty sets.

    This change ensures that those port info dict fields are always set.

    Closes-Bug: #1783556

    Change-Id: I9e5325aa2d8525231353ba451e8ea895be51b1ca
    (cherry picked from commit da5b13df2b2a8171f60311414250671820390738)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.4

This issue was fixed in the openstack/neutron 12.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.6

This issue was fixed in the openstack/neutron 11.0.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b1

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ocata-eol

This issue was fixed in the openstack/neutron ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.