Bug #1783470 “get_subnet_for_dvr returns SNAT mac instead of gat...” : Bugs : neutron

Revision history for this message

Arjun Baindur (abaindur) wrote on 2018-07-25:

#1

The problem appears to be the internal_gateway_ports returned by self.plugin.get_ports() when called with a filter of the SNAT port. On our snat host, this is the very first port that is used when querying the subnet info.

The subnet is the same, as is the gateway, so why is the gateway_mac returned different depending on query port?

2018-07-25 05:26:25.643 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: get_subnet_for_dvr: filter = {'fixed_ips': {'subnet_id': [u'3707b250-b6f5-4701-9b17-01a8f288c17a'], 'ip_address': [u'172.16.0.3']}}
2018-07-25 05:26:25.766 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: internal_gateway_ports = [{'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}]
2018-07-25 05:26:25.767 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: using internal_port['mac_address'] = {'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}

The problem appears to be the internal_gateway_ports returned by self.plugin.get_ports() when called with a filter of the SNAT port. On our snat host, this is the very first port that is used when querying the subnet info.

The subnet is the same, as is the gateway, so why is the gateway_mac returned different depending on query port?

2018-07-25 05:26:25.643 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: get_subnet_for_dvr: filter = {'fixed_ips': {'subnet_id': [u'3707b250-b6f5-4701-9b17-01a8f288c17a'], 'ip_address': [u'172.16.0.3']}}
2018-07-25 05:26:25.766 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: internal_gateway_ports = [{'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}]
2018-07-25 05:26:25.767 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: using internal_port['mac_address'] = {'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}

Revision history for this message

Arjun Baindur (abaindur) wrote on 2018-07-25:

#2

Download full text (3.4 KiB)

2018-07-25 05:26:25.525 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: get_subnet_for_dvr: fixed_ips = [{u'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', u'ip_address': u'172.16.0.3'}] subnet_info = 3707b250-b6f5-4701-9b17-01a8f288c17a
2018-07-25 05:26:25.642 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: got subnet_info: {'description': None, 'tags': [], 'ipv6_ra_mode': None, 'allocation_pools': [{'start': u'172.16.0.2', 'end': u'172.16.255.254'}], 'host_routes': [], 'revision_number': 2L, 'ipv6_address_mode': None, 'cidr': u'172.16.0.0/16', 'id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'subnetpool_id': None, 'service_types': [], 'name': u'172.16.0.0/16', 'enable_dhcp': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'f175f441ebbb4c2b8fedf6469d6415fc', 'dns_nameservers': [u'10.1.10.19', u'8.8.8.8', u'8.8.4.4'], 'gateway_ip': u'172.16.0.1', 'ip_version': 4L, 'shared': True, 'project_id': u'f175f441ebbb4c2b8fedf6469d6415fc'}
2018-07-25 05:26:25.643 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: get_subnet_for_dvr: filter = {'fixed_ips': {'subnet_id': [u'3707b250-b6f5-4701-9b17-01a8f288c17a'], 'ip_address': [u'172.16.0.3']}}
2018-07-25 05:26:25.766 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: internal_gateway_ports = [{'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}]
2018-07-25 05:26:25.767 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: using internal_port['mac_address'] = {'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'371764...

2018-07-25 05:26:25.525 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: get_subnet_for_dvr: fixed_ips = [{u'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', u'ip_address': u'172.16.0.3'}] subnet_info = 3707b250-b6f5-4701-9b17-01a8f288c17a
2018-07-25 05:26:25.642 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: got subnet_info: {'description': None, 'tags': [], 'ipv6_ra_mode': None, 'allocation_pools': [{'start': u'172.16.0.2', 'end': u'172.16.255.254'}], 'host_routes': [], 'revision_number': 2L, 'ipv6_address_mode': None, 'cidr': u'172.16.0.0/16', 'id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'subnetpool_id': None, 'service_types': [], 'name': u'172.16.0.0/16', 'enable_dhcp': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'f175f441ebbb4c2b8fedf6469d6415fc', 'dns_nameservers': [u'10.1.10.19', u'8.8.8.8', u'8.8.4.4'], 'gateway_ip': u'172.16.0.1', 'ip_version': 4L, 'shared': True, 'project_id': u'f175f441ebbb4c2b8fedf6469d6415fc'}
2018-07-25 05:26:25.643 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: get_subnet_for_dvr: filter = {'fixed_ips': {'subnet_id': [u'3707b250-b6f5-4701-9b17-01a8f288c17a'], 'ip_address': [u'172.16.0.3']}}
2018-07-25 05:26:25.766 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: internal_gateway_ports = [{'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}]
2018-07-25 05:26:25.767 1033 INFO neutron.db.dvr_mac_db [req-d69336a0-3db0-4e8a-b24f-b0446c5d9735 - - - - -] ARJUN: using internal_port['mac_address'] = {'status': u'ACTIVE', 'dns_name': '', 'binding:host_id': u'25f77b4e-1f9d-45c3-937e-49eed272faaf', 'description': None, 'allowed_address_pairs': [], 'tags': [], 'extra_dhcp_opts': [], 'dns_assignment': [{'hostname': u'host-172-16-0-3', 'ip_address': u'172.16.0.3', 'fqdn': u'host-172-16-0-3.platform9.sys.'}], 'device_owner': u'network:router_centralized_snat', 'revision_number': 242L, 'port_security_enabled': True, 'binding:profile': {}, 'fixed_ips': [{'subnet_id': u'3707b250-b6f5-4701-9b17-01a8f288c17a', 'ip_address': u'172.16.0.3'}], 'id': u'bc6797ed-2aa8-4764-b42f-852438d21bd5', 'security_groups': [], 'device_id': u'37176403-cfb0-478d-b51c-971d89597cf5', 'name': u'', 'admin_state_up': True, 'network_id': u'3f6ec232-7649-4639-b828-c3af9960481b', 'tenant_id': u'', 'binding:vif_details': {u'port_filter': True, u'ovs_hybrid_plug': True}, 'binding:vnic_type': u'normal', 'binding:vif_type': u'ovs', 'mac_address': u'fa:16:3e:84:0b:42', 'project_id': u''}

Revision history for this message

Arjun Baindur (abaindur) wrote on 2018-07-25:

#3

Should we never have _bind_centralized_snat_port_on_dvr_subnet() call get_subnet_for_dvr() to populate the subnet_info into the local_dvr_map here? https://github.com/openstack/neutron/blob/stable/pike/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py#L534

The server side handle for this returns the MAC as subnet_info['gateway_mac'] = internal_port['mac_address']. If this happens first, then the subnet_info is cached forever with the SNAT port's MAC: https://github.com/openstack/neutron/blob/stable/pike/neutron/db/dvr_mac_db.py#L200

Instead, the get_subnet_for_dvr should only be populated via _bind_distributed_router_interface_port(), as this invokes the RPC call w/ the correct port, the distributed gateway with the DVR MAC: https://github.com/openstack/neutron/blob/stable/pike/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py#L360

If there is an explicit need to populate the local subnet when processing the SNAT port, the server side handler should find a way to return the DVR mac always, not the port's MAC address

Revision history for this message

YAMAMOTO Takashi (yamamoto) wrote on 2018-07-27:

#4

is this pike?

Revision history for this message

Arjun Baindur (abaindur) wrote on 2018-07-27:

#5

Yes, Pike. This code too, appears the same in master/queens. I fixed it locally by setting fixed_ips=None in the call to self.plugin_rpc.get_subnet_for_dvr. After that, the dvr_to_src_mac flows are added with correct MAC.

BTW this issue seems to be random(ordering of distributed vs snat port). I observed a dvr_snat node on another env where the flows were added with the router_distributed port's MAC. But then when I restarted ovs-agent, the _bind_centralized_snat_port_on_dvr_subnet handler was invoked first for the SNAT port, and so the subnet_info used the MAC from this port instead.

Changed fixed_ips to =None here: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py#L541

    def _bind_centralized_snat_port_on_dvr_subnet(self, port, lvm,
                                                  fixed_ips, device_owner):
        # since centralized-SNAT (CSNAT) port must have only one fixed
        # IP, directly use fixed_ips[0]
        fixed_ip = fixed_ips[0]
        if port.vif_id in self.local_ports:
            # throw an error if CSNAT port is already on a different
            # dvr routed subnet
            ovsport = self.local_ports[port.vif_id]
            subs = list(ovsport.get_subnets())
            if subs[0] == fixed_ip['subnet_id']:
                return
            LOG.error("Centralized-SNAT port %(port)s on subnet "
                      "%(port_subnet)s already seen on a different "
                      "subnet %(orig_subnet)s", {
                          "port": port.vif_id,
                          "port_subnet": fixed_ip['subnet_id'],
                          "orig_subnet": subs[0],
                      })
            return
        subnet_uuid = fixed_ip['subnet_id']
        ldm = None
        subnet_info = None
        if subnet_uuid not in self.local_dvr_map:
            # no csnat ports seen on this subnet - create csnat state
            # for this subnet
            subnet_info = self.plugin_rpc.get_subnet_for_dvr(
                self.context, subnet_uuid, fixed_ips=None)
            if not subnet_info:
                LOG.warning("DVR: Unable to retrieve subnet information "
                            "for subnet_id %s. The subnet or the gateway "
                            "may have already been deleted", subnet_uuid)
                return
            LOG.debug("get_subnet_for_dvr for subnet %(uuid)s "
                      "returned with %(info)s",
                      {"uuid": subnet_uuid, "info": subnet_info})
            ldm = LocalDVRSubnetMapping(subnet_info, port.ofport)
            self.local_dvr_map[subnet_uuid] = ldm
        else:
            ldm = self.local_dvr_map[subnet_uuid]
            subnet_info = ldm.get_subnet_info()
            # Store csnat OF Port in the existing DVRSubnetMap
            ldm.set_csnat_ofport(port.ofport)

Yes, Pike. This code too, appears the same in master/queens. I fixed it locally by setting fixed_ips=None in the call to self.plugin_rpc.get_subnet_for_dvr. After that, the dvr_to_src_mac flows are added with correct MAC.

BTW this issue seems to be random(ordering of distributed vs snat port). I observed a dvr_snat node on another env where the flows were added with the router_distributed port's MAC. But then when I restarted ovs-agent, the _bind_centralized_snat_port_on_dvr_subnet handler was invoked first for the SNAT port, and so the subnet_info used the MAC from this port instead.

Changed fixed_ips to =None here: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py#L541

def _bind_centralized_snat_port_on_dvr_subnet(self, port, lvm,
                                                  fixed_ips, device_owner):
        # since centralized-SNAT (CSNAT) port must have only one fixed
        # IP, directly use fixed_ips[0]
        fixed_ip = fixed_ips[0]
        if port.vif_id in self.local_ports:
            # throw an error if CSNAT port is already on a different
            # dvr routed subnet
            ovsport = self.local_ports[port.vif_id]
            subs = list(ovsport.get_subnets())
            if subs[0] == fixed_ip['subnet_id']:
                return
            LOG.error("Centralized-SNAT port %(port)s on subnet "
                      "%(port_subnet)s already seen on a different "
                      "subnet %(orig_subnet)s", {
                          "port": port.vif_id,
                          "port_subnet": fixed_ip['subnet_id'],
                          "orig_subnet": subs[0],
                      })
            return
        subnet_uuid = fixed_ip['subnet_id']
        ldm = None
        subnet_info = None
        if subnet_uuid not in self.local_dvr_map:
            # no csnat ports seen on this subnet - create csnat state
            # for this subnet
            subnet_info = self.plugin_rpc.get_subnet_for_dvr(
                self.context, subnet_uuid, fixed_ips=None)
            if not subnet_info:
                LOG.warning("DVR: Unable to retrieve subnet information "
                            "for subnet_id %s. The subnet or the gateway "
                            "may have already been deleted", subnet_uuid)
                return
            LOG.debug("get_subnet_for_dvr for subnet %(uuid)s "
                      "returned with %(info)s",
                      {"uuid": subnet_uuid, "info": subnet_info})
            ldm = LocalDVRSubnetMapping(subnet_info, port.ofport)
            self.local_dvr_map[subnet_uuid] = ldm
        else:
            ldm = self.local_dvr_map[subnet_uuid]
            subnet_info = ldm.get_subnet_info()
            # Store csnat OF Port in the existing DVRSubnetMap
            ldm.set_csnat_ofport(port.ofport)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-30: Fix proposed to neutron (master)

#6

Fix proposed to branch: master
Review: https://review.openstack.org/587234

Changed in neutron:
assignee:	nobody → Arjun Baindur (abaindur)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2018-08-09

Changed in neutron:
assignee:	Arjun Baindur (abaindur) → Swaminathan Vasudevan (swaminathan-vasudevan)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-13: Fix merged to neutron (master)

#7

Reviewed: https://review.openstack.org/587234
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c6de172e58ed4cbd157c2e560ffbbb4dc3a34730
Submitter: Zuul
Branch: master

commit c6de172e58ed4cbd157c2e560ffbbb4dc3a34730
Author: Arjun Baindur <email address hidden>
Date: Mon Jul 30 14:22:30 2018 -0700

get_subnet_for_dvr returns SNAT mac instead of distributed gateway in subnet_info

    On hosts with dvr_snat agent mode, after restarting OVS agent,
    sometimes the SNAT port is processed first instead of the distributed port.
    The subnet_info is cached locally via get_subnet_for_dvr when either of these ports
    are processed. However, it returns the MAC address of the port used to query
    as the gateway for the subnet. Using the SNAT port, this puts the wrong
    MAC as the gateway, causing some flows such as the DVR flows on br-int
    for local src VMs to have the wrong MAC.

    This patch fixes the get_subnet_for_dvr with fixed_ips as None for the csnat port,
    as that causes the server side handler to fill in the subnet's actual gateway
    rather than using the port's MAC.

Change-Id: If045851819fd53c3b9a1506cc52bc1757e6d6851
Closes-Bug: #1783470

Changed in neutron:
status:	In Progress → Fix Released

Bernard Cafarelli (bcafarel) on 2018-08-17

tags:	added: neutron-proactive-backport-potential
tags:	added: neutron-easy-proactive-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-17: Fix proposed to neutron (stable/rocky)

#8

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/593002

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-17: Fix proposed to neutron (stable/queens)

#9

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/593013

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-17: Fix proposed to neutron (stable/pike)

#10

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/593019

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-17: Fix proposed to neutron (stable/ocata)

#11

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/593026

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-22: Fix merged to neutron (stable/rocky)

#12

Reviewed: https://review.openstack.org/593002
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd915e8238188ca8609292d50d31e1c840f0fdb5
Submitter: Zuul
Branch: stable/rocky

commit dd915e8238188ca8609292d50d31e1c840f0fdb5
Author: Arjun Baindur <email address hidden>
Date: Mon Jul 30 14:22:30 2018 -0700

get_subnet_for_dvr returns SNAT mac instead of distributed gateway in subnet_info

    On hosts with dvr_snat agent mode, after restarting OVS agent,
    sometimes the SNAT port is processed first instead of the distributed port.
    The subnet_info is cached locally via get_subnet_for_dvr when either of these ports
    are processed. However, it returns the MAC address of the port used to query
    as the gateway for the subnet. Using the SNAT port, this puts the wrong
    MAC as the gateway, causing some flows such as the DVR flows on br-int
    for local src VMs to have the wrong MAC.

    This patch fixes the get_subnet_for_dvr with fixed_ips as None for the csnat port,
    as that causes the server side handler to fill in the subnet's actual gateway
    rather than using the port's MAC.

    Change-Id: If045851819fd53c3b9a1506cc52bc1757e6d6851
    Closes-Bug: #1783470
    (cherry picked from commit c6de172e58ed4cbd157c2e560ffbbb4dc3a34730)

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-23: Fix included in openstack/neutron 13.0.0.0rc2

#13

This issue was fixed in the openstack/neutron 13.0.0.0rc2 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-05: Fix merged to neutron (stable/queens)

#14

Reviewed: https://review.openstack.org/593013
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b600368d8f35cad28ead132f44b171ed1387b20a
Submitter: Zuul
Branch: stable/queens

commit b600368d8f35cad28ead132f44b171ed1387b20a
Author: Arjun Baindur <email address hidden>
Date: Mon Jul 30 14:22:30 2018 -0700

get_subnet_for_dvr returns SNAT mac instead of distributed gateway in subnet_info

    On hosts with dvr_snat agent mode, after restarting OVS agent,
    sometimes the SNAT port is processed first instead of the distributed port.
    The subnet_info is cached locally via get_subnet_for_dvr when either of these ports
    are processed. However, it returns the MAC address of the port used to query
    as the gateway for the subnet. Using the SNAT port, this puts the wrong
    MAC as the gateway, causing some flows such as the DVR flows on br-int
    for local src VMs to have the wrong MAC.

    This patch fixes the get_subnet_for_dvr with fixed_ips as None for the csnat port,
    as that causes the server side handler to fill in the subnet's actual gateway
    rather than using the port's MAC.

    Change-Id: If045851819fd53c3b9a1506cc52bc1757e6d6851
    Closes-Bug: #1783470
    (cherry picked from commit c6de172e58ed4cbd157c2e560ffbbb4dc3a34730)

tags:

added: in-stable-queens

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-08: Fix merged to neutron (stable/ocata)

#15

Reviewed: https://review.openstack.org/593026
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9c1d2c68fbf038ed2746762893f7ab8cc23dee11
Submitter: Zuul
Branch: stable/ocata

commit 9c1d2c68fbf038ed2746762893f7ab8cc23dee11
Author: Arjun Baindur <email address hidden>
Date: Mon Jul 30 14:22:30 2018 -0700

get_subnet_for_dvr returns SNAT mac instead of distributed gateway in subnet_info

    On hosts with dvr_snat agent mode, after restarting OVS agent,
    sometimes the SNAT port is processed first instead of the distributed port.
    The subnet_info is cached locally via get_subnet_for_dvr when either of these ports
    are processed. However, it returns the MAC address of the port used to query
    as the gateway for the subnet. Using the SNAT port, this puts the wrong
    MAC as the gateway, causing some flows such as the DVR flows on br-int
    for local src VMs to have the wrong MAC.

    This patch fixes the get_subnet_for_dvr with fixed_ips as None for the csnat port,
    as that causes the server side handler to fill in the subnet's actual gateway
    rather than using the port's MAC.

    Change-Id: If045851819fd53c3b9a1506cc52bc1757e6d6851
    Closes-Bug: #1783470
    (cherry picked from commit c6de172e58ed4cbd157c2e560ffbbb4dc3a34730)

tags:

added: in-stable-ocata

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-09: Fix merged to neutron (stable/pike)

#16

Reviewed: https://review.openstack.org/593019
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cefafe3cc30daf116802e772f4162f2ac35d0c18
Submitter: Zuul
Branch: stable/pike

commit cefafe3cc30daf116802e772f4162f2ac35d0c18
Author: Arjun Baindur <email address hidden>
Date: Mon Jul 30 14:22:30 2018 -0700

get_subnet_for_dvr returns SNAT mac instead of distributed gateway in subnet_info

    On hosts with dvr_snat agent mode, after restarting OVS agent,
    sometimes the SNAT port is processed first instead of the distributed port.
    The subnet_info is cached locally via get_subnet_for_dvr when either of these ports
    are processed. However, it returns the MAC address of the port used to query
    as the gateway for the subnet. Using the SNAT port, this puts the wrong
    MAC as the gateway, causing some flows such as the DVR flows on br-int
    for local src VMs to have the wrong MAC.

    This patch fixes the get_subnet_for_dvr with fixed_ips as None for the csnat port,
    as that causes the server side handler to fill in the subnet's actual gateway
    rather than using the port's MAC.

    Change-Id: If045851819fd53c3b9a1506cc52bc1757e6d6851
    Closes-Bug: #1783470
    (cherry picked from commit c6de172e58ed4cbd157c2e560ffbbb4dc3a34730)

tags:

added: in-stable-pike

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-18: Fix included in openstack/neutron 12.0.4

#17

This issue was fixed in the openstack/neutron 12.0.4 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-11-06: Fix included in openstack/neutron 11.0.6

#18

This issue was fixed in the openstack/neutron 11.0.6 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-21: Fix included in openstack/neutron 14.0.0.0b1

#19

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-14: Fix included in openstack/neutron ocata-eol

#20

This issue was fixed in the openstack/neutron ocata-eol release.

neutron

get_subnet_for_dvr returns SNAT mac instead of gateway in subnet_info

Bug Description

Other bug subscribers

Remote bug watches