No packet log if disable the ovs-agent DEBUG log level

[LIU Yulong]

ENV:
neutron: stable/queens 12.0.2
$ uname -r
3.10.0-862.3.2.el7.x86_64

$ sudo ovs-appctl vlog/list
                 console syslog file
                 ------- ------ ------
backtrace OFF DBG INFO
...
ALL-app OFF DBG INFO

Configrations:
neutron.conf
service_plugins = ...,log

openvswitch_agent.ini
[agent]=
extensions = ...,log

[network_log]
rate_limit = 100
burst_limit = 25

Neutron security group resource logging presents in ovs-agent.log:
http://paste.openstack.org/show/725657/, here line 2 is the DROP action log.

As the doc file says "log information is written to the destination if configured in local_output_log_base or system journal like /var/log/syslog."
https://docs.openstack.org/neutron/queens/admin/config-logging.html

So, if I disable the ovs-agent DEBUG leve service log, the resource LOG will not see anymore.

[LIU Yulong (dragon889)]

Here are some irc log related to this bug:
http://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2018-07-12.log.html#t2018-07-12T07:51:50

[LIU Yulong (dragon889)]

Resource in detail:
neutron security group list and LOG list:
http://paste.openstack.org/show/725782/
compute node ovs flows:
http://paste.openstack.org/show/725783/

[YAMAMOTO Takashi (yamamoto)]

as far as i know, security group logging and debug log are two different things.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/587770

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/587770
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f937dd2a150f77f9c3de489acdafe2bdce13fdbe
Submitter: Zuul
Branch: master

commit f937dd2a150f77f9c3de489acdafe2bdce13fdbe
Author: Nguyen Phuong An <email address hidden>
Date: Wed Aug 1 17:29:26 2018 +0700

    Fix no packet log data when debug is set False in configuration

    In production environment, it's quite difficult to require operator
    to enable debug log level. This patch changes LOG.debug to LOG.info
    of packet_in_handler function. Therefore operator can get packet log
    data while debug=False or True in config file. This patch also adds
    timestamp to log_file if local_output_log_base is specified.

    Partial-Bug #1781372
    Change-Id: I729e57caecd502d018084c3c766278006bcbf0c9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/591543

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/591545

[Akihiro Motoki (amotoki)]

Review 587770 says "Partial-Bug". Do we need other change to close the bug?

[Akihiro Motoki (amotoki)]

Per discussion with annp, the issue reported in the original bug can be separated into two topics:
1) no packet log when disable debug log level (i.e. log level higher than debug)
2) duplicated packet log in ovs-agent.log and log file specified by the configuration

These two are separate topics.

This bug focused on 1) and bug 1786934 is used to track 2).

[Akihiro Motoki (amotoki)]

Per #9, this bug can be marked as "Fix Released".

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/591543
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8e0b41236e73bda8828a98bc1f106fe7cda627f6
Submitter: Zuul
Branch: stable/rocky

commit 8e0b41236e73bda8828a98bc1f106fe7cda627f6
Author: Nguyen Phuong An <email address hidden>
Date: Wed Aug 1 17:29:26 2018 +0700

    Fix no packet log data when debug is set False in configuration

    In production environment, it's quite difficult to require operator
    to enable debug log level. This patch changes LOG.debug to LOG.info
    of packet_in_handler function. Therefore operator can get packet log
    data while debug=False or True in config file. This patch also adds
    timestamp to log_file if local_output_log_base is specified.

    Closes-Bug #1781372
    Change-Id: I729e57caecd502d018084c3c766278006bcbf0c9
    (cherry picked from commit f937dd2a150f77f9c3de489acdafe2bdce13fdbe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/591545
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d1943af70bd600b31bd4f0da7b5bd5f2163a71d6
Submitter: Zuul
Branch: stable/queens

commit d1943af70bd600b31bd4f0da7b5bd5f2163a71d6
Author: Nguyen Phuong An <email address hidden>
Date: Wed Aug 1 17:29:26 2018 +0700

    Fix no packet log data when debug is set False in configuration

    In production environment, it's quite difficult to require operator
    to enable debug log level. This patch changes LOG.debug to LOG.info
    of packet_in_handler function. Therefore operator can get packet log
    data while debug=False or True in config file. This patch also adds
    timestamp to log_file if local_output_log_base is specified.

    Closes-Bug #1781372
    Change-Id: I729e57caecd502d018084c3c766278006bcbf0c9
    (cherry picked from commit f937dd2a150f77f9c3de489acdafe2bdce13fdbe)