The transition of a router from distributed to centralized may mistakenly get HA enabled

[Kailun Qin]

The transition of a router's 'distributed' attribute from True to False may mistakenly get its 'ha' attribute updated at the same time. The side-effect is that the router may become HA enabled unexpectedly, which does not respect the user's request.

Steps to reproduce:
1. neutron router-create test
2. neutron router-show test # HA=false
3. neutron router-update test --admin_state_up false
4. neutron router-update test --distributed true
5. neutron router-update test --admin_state_up true
6. neutron router-show test # HA=false => expected
7. neutron router-update test --admin_state_up false
8. neutron router-update test --distributed false
9. neutron router-update test --admin_state_up true
10. neutron router-show test # HA=true => unexpected

For further detailed information, please kindly refer to the failed CLI log attached.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/580173

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/580173
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=886e24155358afe7ad167ba1602d3939d68c3d5f
Submitter: Zuul
Branch: master

commit 886e24155358afe7ad167ba1602d3939d68c3d5f
Author: Kailun Qin <email address hidden>
Date: Thu Jul 5 07:17:31 2018 +0800

    Fix attribute mismatch in router provider update

    The transition of a router from distributed to centralized may
    mistakenley get its 'ha' attribute updated at the same time. The
    side-effect is that the router may become HA enabled unexpectedly.

    This patch fixed the mismatched attribute in _update_router_provider
    method which addressed the issue cited above.

    Closes-Bug: #1780094
    Change-Id: Ib00de137692979229d1b7ba033ecff04e9cc9db0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/591867

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/584229
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/591867
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=03f65602dfeac04f202ce8eb7e68c6cdcf8cdc15
Submitter: Zuul
Branch: stable/queens

commit 03f65602dfeac04f202ce8eb7e68c6cdcf8cdc15
Author: Kailun Qin <email address hidden>
Date: Thu Apr 18 20:57:20 2019 +0800

    Fix attribute mismatch in router provider update

    The transition of a router from distributed to centralized may
    mistakenley get its 'ha' attribute updated at the same time. The
    side-effect is that the router may become HA enabled unexpectedly.

    This patch fixed the mismatched attribute in _update_router_provider
    method which addressed the issue cited above.

    Closes-Bug: #1780094
    Change-Id: Ib00de137692979229d1b7ba033ecff04e9cc9db0
    (cherry picked from commit 886e24155358afe7ad167ba1602d3939d68c3d5f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/584229
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=ce246d0b487d9ddc66aa0abe749ab54fca8476a9
Submitter: Zuul
Branch: master

commit ce246d0b487d9ddc66aa0abe749ab54fca8476a9
Author: Kailun Qin <email address hidden>
Date: Fri Jul 20 21:38:07 2018 +0800

    Add api test for DVR coverting back to centralized

    This patch adds a test case for DVR routers which converts a centralized
    router to distributed firstly, followed by making a transition back to
    centralized. It checks whether the attributes are updated or retained as
    expected.

    Related-Bug: #1780094
    Change-Id: Ida6e75d0215283c15b7a1c0ce0f473169afe8a66

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.1.0 release.