missing transaction in driver_controller.py for l3 flavors

[Manjeet Singh Bhatia]

All the operations related to router associations like add or delete etc were executed under transactions, there was a case 'get_provider_for_router' doing add_resource_association out of db transaction, luckily due to autocommit there were no issues.

https://github.com/openstack/neutron/blob/master/neutron/services/l3_router/service_providers/driver_controller.py#L160

need to be in under transaction.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/577246

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/577246
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d97cce0403eb0ca10fb26ba23facb37c86934835
Submitter: Zuul
Branch: master

commit d97cce0403eb0ca10fb26ba23facb37c86934835
Author: Manjeet Singh Bhatia <email address hidden>
Date: Thu Jun 21 18:17:41 2018 +0000

    Add missing transaction in driver_controller.

    All the operations related to router associations (add/del)
    were executed under transactions, there was a case
    'get_provider_for_router' doing add_resource_association
    out of db transaction, luckily due to autocommit there were no
    issues but this patch adds the missing transaction.

    Closes-Bug: #1778118

    Change-Id: Iaec9a40614c7e6ce1120e9fa7ef3a4fdb4d59963

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b3 development milestone.