DVR: FloatingIP create throws an error if the L3 agent is not running in the given host

[Swaminathan Vasudevan]

FloatingIP create throws an error if the L3 agent is not running on the given host for DVR Routers.
This can be reproduced by
1. Configure the global router settings to be 'Legacy' CVR routers.
2. Then configure a DVR Router by manually setting '--distributed = True' from CLI.
3. Create a network
4. Create a Subnet
5. Attach the subnet to the DVR router
6. Configure the Gateway for the Router.
7. Then create a VM on the created Subnet
8. Now create a FloatingIP and associate it with the VM port.
9. You would see an 'Internal Server Error' while creating the FloatingIP.

~/devstack$ neutron floatingip-associate 1cafc567-c6fc-4424-9c44-ab7d90bc6ce0 5c95fa16-a8cc-4d93-8f31-988f692e01ae
neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
Request Failed: internal server error while processing your request.

The reason is before creating the 'FloatingIP Agent Gateway Port' it checks for the Agent type by the given host, and it raises an Exception since the Agent is not running on the Compute Host.

This is basically a Test Error, but still we should handle the error condition and not throw an Internal Server Error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/574917

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/574917
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ceca4d9d1041345ccfeab675c8e8216050f7135
Submitter: Zuul
Branch: master

commit 5ceca4d9d1041345ccfeab675c8e8216050f7135
Author: Swaminathan Vasudevan <email address hidden>
Date: Tue Jun 12 15:22:57 2018 -0700

    DVR: FloatingIP create throws an error if no l3 agent

    FloatingIP create throws an error if the L3 agent is not running
    on the given host for DVR Routers.
    This happens when we try to create a DVR Router in the Legacy
    Router deployed cloud.
    FloatingIP create checks for the agent type based on the host,
    and when agents are not available on the given host, it raises
    an exception.
    This patch will fixes by handling the exception raised, when the
    agent is not available.

    Change-Id: I80522d12087495861e832cf1c7a3fe9a7830d386
    Closes-Bug: #1776566

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/576922

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/577012

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576922
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=65fcbc212dc0d119b5ed60cc390e73714fedd1a7
Submitter: Zuul
Branch: stable/queens

commit 65fcbc212dc0d119b5ed60cc390e73714fedd1a7
Author: Swaminathan Vasudevan <email address hidden>
Date: Tue Jun 12 15:22:57 2018 -0700

    DVR: FloatingIP create throws an error if no l3 agent

    FloatingIP create throws an error if the L3 agent is not running
    on the given host for DVR Routers.
    This happens when we try to create a DVR Router in the Legacy
    Router deployed cloud.
    FloatingIP create checks for the agent type based on the host,
    and when agents are not available on the given host, it raises
    an exception.
    This patch will fixes by handling the exception raised, when the
    agent is not available.

    Change-Id: I80522d12087495861e832cf1c7a3fe9a7830d386
    Closes-Bug: #1776566
    (cherry picked from commit 5ceca4d9d1041345ccfeab675c8e8216050f7135)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.4 release.

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/pike
Review: https://review.opendev.org/577012
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.