Test failures in docker container

[Pavlukhin Max]

There are no enough resources to create the pool of virtual machines sometimes. People use containers in this case.

There are two tests that fail in docker container:
http://paste.openstack.org/show/722171/

The main reason is that docker container is not a Virtual Machine, so it doesn't provide all of the architecture in the same way that a Virtual Machine might. The underlying infrastructure of docker containers is configured on the Host system, not within the container itself

These tests use brctl and sysctl. You can use --privileged flag ('docker run' command) for brctl. What about sysctl? You can use sysctl commands with docker-client. But you can not use it inside a container.

It would be very cool if the tests were fixed so that they work in docker containers.

[Antonio Ojea (aojea)]

Do you have an example of the Dockerfile you are using to run these tests?

[Pavlukhin Max (mpavlukhin)]

Yes, of course

[Antonio Ojea (aojea)]

I'm able to run all unit tests now without any failure, I had to enable ipv6 in docker [1] and run the container with the following arguments:

# sudo docker run --sysctl net.ipv6.conf.all.disable_ipv6=0 --privileged bash

The problem was the sysctl call as you pointed out, but it turned out that it failed only with the ipv6 calls because of [2].

[1] https://docs.docker.com/config/daemon/ipv6/
[2] https://github.com/moby/moby/issues/32619

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/570871

[YAMAMOTO Takashi (yamamoto)]

brctl and sysctl should be mocked for unit tests.
otherwise, those test cases should be moved to functional tests.

[Antonio Ojea (aojea)]

yamamoto It seems that the problem is that the function disable_ipv6() [1] is not mocked.
Both tests work if you mock or remove the disable_ipv6() function, but I guess that the best approach is to remove it because it looks that since this patch [2] ipv6 is no longer disabled in the bridges.

[1] https://github.com/openstack/neutron/blob/9cb96b873e1aab05076a1e58144cda073140fbfc/neutron/tests/unit/agent/linux/test_bridge_lib.py#L70

[2] https://review.openstack.org/#/c/431619/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Antonio Ojea (<email address hidden>) on branch: master
Review: https://review.openstack.org/571219
Reason: Duplicate https://review.openstack.org/#/c/570270/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/570270
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8930d33c71e394c1cfaa1b9ad5493c79d394cb40
Submitter: Zuul
Branch: master

commit 8930d33c71e394c1cfaa1b9ad5493c79d394cb40
Author: Slawek Kaplonski <email address hidden>
Date: Wed May 23 15:13:42 2018 -0700

    Fix UT BridgeLibTest when IPv6 is disabled

    There was missing mock of
    ipv6_utils.is_enabled_and_bind_by_default() in BridgeLibTest
    unit tests and that cause failing some of tests from this module
    when tests are running on host with disabled IPv6.
    Now it's mocked and tests are running properly and are
    testing what they should test.

    Closes-Bug: #1773818
    Change-Id: I9144450ce85e020c0e33c5214a2178acbbbf5f54

[OpenStack Infra (hudson-openstack)]

Change abandoned by Antonio Ojea (<email address hidden>) on branch: master
Review: https://review.openstack.org/570871

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/582630

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/582631

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582631
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=45ae2e45c41c2418ebc58fbd0f2921ab662fd4c4
Submitter: Zuul
Branch: stable/pike

commit 45ae2e45c41c2418ebc58fbd0f2921ab662fd4c4
Author: Slawek Kaplonski <email address hidden>
Date: Wed May 23 15:13:42 2018 -0700

    Fix UT BridgeLibTest when IPv6 is disabled

    There was missing mock of
    ipv6_utils.is_enabled_and_bind_by_default() in BridgeLibTest
    unit tests and that cause failing some of tests from this module
    when tests are running on host with disabled IPv6.
    Now it's mocked and tests are running properly and are
    testing what they should test.

    Closes-Bug: #1773818
    Change-Id: I9144450ce85e020c0e33c5214a2178acbbbf5f54
    (cherry picked from commit 8930d33c71e394c1cfaa1b9ad5493c79d394cb40)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582630
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f001b273b7f3241a96d08c30c767abce621609cd
Submitter: Zuul
Branch: stable/queens

commit f001b273b7f3241a96d08c30c767abce621609cd
Author: Slawek Kaplonski <email address hidden>
Date: Wed May 23 15:13:42 2018 -0700

    Fix UT BridgeLibTest when IPv6 is disabled

    There was missing mock of
    ipv6_utils.is_enabled_and_bind_by_default() in BridgeLibTest
    unit tests and that cause failing some of tests from this module
    when tests are running on host with disabled IPv6.
    Now it's mocked and tests are running properly and are
    testing what they should test.

    Closes-Bug: #1773818
    Change-Id: I9144450ce85e020c0e33c5214a2178acbbbf5f54
    (cherry picked from commit 8930d33c71e394c1cfaa1b9ad5493c79d394cb40)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.6 release.