Standard attributes are missing in segment response

[Hongbin Lu]

The response of segment resource doesn't contain standard attributes, i.e. created_at, updated_at, revision_number. These attributes should be visible in the response as other resources.

[Lujin Luo (luo-lujin)]

Hi @Hongbin, yes, we do not have standard attributes in segment resource now. Just out of curiosity, any reason you want to add such information to it. Any specific use cases?

[Hongbin Lu (hongbin.lu)]

@Lujin,

These information has already been added into the DB table (note that NetworkSegment inherits from HasStandardAttribute [1]). They are just not exposed by the REST API. I see this issue as a bug rather than a feature request.

[Hongbin Lu (hongbin.lu)]

With that said, I don't have particular use case on segment resource, but I would like to align segment with the rest of the standard API resource. This will improve the consistency of the API which will benefit our users in general.

[Lujin Luo (luo-lujin)]

@Hongbin, understood. I wanted to mark it as confirmed but if you have already proposed any patches please link it here, and I will keep the status as in progress.

[Hongbin Lu (hongbin.lu)]

Proposed patch: https://review.openstack.org/#/c/558318/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558318
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4d84c10ba4430752bf8c1227c770fb3c4f0a1618
Submitter: Zuul
Branch: master

commit 4d84c10ba4430752bf8c1227c770fb3c4f0a1618
Author: Hongbin Lu <email address hidden>
Date: Mon Apr 2 23:11:38 2018 +0000

    Add standard attributes to segment resource

    Standard attributes (i.e. revision_number, created_at, updated_at)
    are missing in the segment resource. This is because the controller
    doesn't process extensions on rendering the response. This patch
    fixes it. In particular, this patch does the following:
    * Process extensions when making the segment dict. This allows
      other extensions to add attributes to segment response.
    * Make segment extension implement update_attributes_map.

    Tempest test: https://review.openstack.org/#/c/558609/

    APIImpact update api reference of segments

    Closes-Bug: #1760902
    Change-Id: I3c93818002c2d7753454547231ba08544b6fa1c0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/562298

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hongbin Lu (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/562298

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/562331

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/567695

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/562331
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=9de5b2ee02afc3020dcda1529288deabfbab33e8
Submitter: Zuul
Branch: master

commit 9de5b2ee02afc3020dcda1529288deabfbab33e8
Author: Hongbin Lu <email address hidden>
Date: Wed Apr 18 16:09:33 2018 +0000

    Add a shim extension standard-attr-segment

    Neutron patch: https://review.openstack.org/#/c/562320/

    Change-Id: I34616a01c6fc0617984272d577650420233041e1
    Related-Bug: #1765008
    Related-Bug: #1760902

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hongbin Lu (<email address hidden>) on branch: master
Review: https://review.openstack.org/567695