OpenStack Bandit scanner violations

[Pavlukhin Max]

There are two issues to fix: B101 assert_used and the B108: hardcoded_tmp_directory found by OpenStack Bandit scanner.

Files with B108 (hardcore_tmp_directory):
    neutron/agent/linux/keepalived.py

Files with B101 (assert_used):
    neutron/common/_deprecate.py
    neutron/common/rpc.py
    neutron/db/api.py
    neutron/pecan_wsgi/controllers/root.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/556838

[OpenStack Infra (hudson-openstack)]

Change abandoned by Max Pavlukhin (<email address hidden>) on branch: master
Review: https://review.openstack.org/556838

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/557366

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/557367

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557366
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6e6166bda47bd1fc8687340e479a913e7fc0ed58
Submitter: Zuul
Branch: master

commit 6e6166bda47bd1fc8687340e479a913e7fc0ed58
Author: Max <email address hidden>
Date: Thu Mar 15 19:05:55 2018 +0400

    Replace assert to raise AssertionError

    This patch is a fix for the issue B101 assert_used found by bandit
    scanner:
    https://docs.openstack.org/bandit/latest/plugins/b101_assert_used.html
    As assert functionality could be turned off by the -O option for python
    interpreter, assert statements were replaced to raise AssertionError.

    The main reasoning for that is rest code after assert could be not
    ready for values that assert filters.

    Change-Id: I92a871b1b496c96c0c76cb37e4dda51bfc007e38
    Related-Bug: #1759250

[OpenStack Infra (hudson-openstack)]

Change abandoned by Max Pavlukhin (<email address hidden>) on branch: master
Review: https://review.openstack.org/557367

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/562271

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pavlukhin Max (<email address hidden>) on branch: master
Review: https://review.openstack.org/562271

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/563956

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pavlukhin Max (<email address hidden>) on branch: master
Review: https://review.openstack.org/563956

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/563958

[OpenStack Infra (hudson-openstack)]

Change abandoned by Max Pavlukhin (<email address hidden>) on branch: master
Review: https://review.openstack.org/563958

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/563960

[OpenStack Infra (hudson-openstack)]

Change abandoned by Max Pavlukhin (<email address hidden>) on branch: master
Review: https://review.openstack.org/563960

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/563970

[OpenStack Infra (hudson-openstack)]

Change abandoned by Max Pavlukhin (<email address hidden>) on branch: master
Review: https://review.openstack.org/563970
Reason: wrong author

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/563971

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563971
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f6b0f7635c222029fc1b554dffceb579b3e4a846
Submitter: Zuul
Branch: master

commit f6b0f7635c222029fc1b554dffceb579b3e4a846
Author: Max Pavlukhin <email address hidden>
Date: Tue Apr 24 17:04:15 2018 +0400

    Eliminate possible insecure usage of temp file/directory

    This patch is a fix for the issue B108: hardcoded_tmp_directory
    found by bandit scanner.

    The main reasoning for that is the need for safely creating
    a temporary file or directory.

    Change-Id: I4277e9196b9b707b83bb298faeccb59f07d6f10b
    Related-Bug: #1759250