DVR: Fix dvr mac address format to be backward compatible with non native openflow interface

[Swaminathan Vasudevan]

DVR MAC address is configured on the server for every node that is configured to run in one of the dvr agent modes ( dvr,dvr_snat and dvr_no_external).

The DVR MAC addresses are stored in the 'AA-BB-CC-DD-EE-FF' format.

When the agent tries to configure the DVR MAC addresses into the openflow rules using the native interface drivers, they are ok.

But when used with the non native interface drivers this throws an error as shown below.

Unable to execute ['ovs-ofctl', 'add-flows', 'br-vlan1078', '-']. Exception: Exit code: 1; Stdin: hard_timeout=0,idle_timeout=0,priority=2,table=3,cookie=12002607947458125225,dl_src=FA-16-3F-AA-78-20,actions=output:2; Stdout: ; Stderr: ovs-ofctl: -:1: FA-16-3F-AA-78-20: invalid Ethernet address.

This is also seen in the Master branch.
So to provide backward compatibility, we need to add a patch to change the format of the MAC before it is handed over to the openflow interface driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/553870

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553870
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6b13cf0bee67e6196201e7863b1facce54b6d6f6
Submitter: Zuul
Branch: master

commit 6b13cf0bee67e6196201e7863b1facce54b6d6f6
Author: Swaminathan Vasudevan <email address hidden>
Date: Wed Mar 14 16:59:32 2018 -0700

    DVR: Fix mac format for backward compatibility with vsctl api

    Fix the mac address format for backward compatibility with
    vsctl ovs api

    Closes-Bug: #1756406
    Change-Id: I3ba11fae433b437d9d3a0b12dd8a11fe1b35046a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/554566

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/554568

[OpenStack Infra (hudson-openstack)]

Change abandoned by Antonio Ojea (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/554568

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554566
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bf03abf433cab77bf952b7b1d34e5f15dfd721a7
Submitter: Zuul
Branch: stable/queens

commit bf03abf433cab77bf952b7b1d34e5f15dfd721a7
Author: Swaminathan Vasudevan <email address hidden>
Date: Wed Mar 14 16:59:32 2018 -0700

    DVR: Fix mac format for backward compatibility with vsctl api

    Fix the mac address format for backward compatibility with
    vsctl ovs api

    Closes-Bug: #1756406
    Change-Id: I3ba11fae433b437d9d3a0b12dd8a11fe1b35046a
    (cherry picked from commit 6b13cf0bee67e6196201e7863b1facce54b6d6f6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.2 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554568
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77152ee76eb588aefc693472ceaa415559bdebf4
Submitter: Zuul
Branch: stable/pike

commit 77152ee76eb588aefc693472ceaa415559bdebf4
Author: Swaminathan Vasudevan <email address hidden>
Date: Wed Mar 14 16:59:32 2018 -0700

    DVR: Fix mac format for backward compatibility with vsctl api

    Fix the mac address format for backward compatibility with
    vsctl ovs api

    Closes-Bug: #1756406
    Change-Id: I3ba11fae433b437d9d3a0b12dd8a11fe1b35046a
    (cherry picked from commit 6b13cf0bee67e6196201e7863b1facce54b6d6f6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.6 release.