Dynamic routing: peer not removed from agent

[Dr. Jens Harbott]

After going through https://docs.openstack.org/neutron-dynamic-routing/latest/contributor/testing.html even after removing both the speaker from the agent and the peer from the speaker, the agent still continues trying to connect to the peer address.

Expected result would be seeing the connection attempts stop.

[Dr. Jens Harbott (j-harbott)]

I traced this back to an issue in ryu, see https://sourceforge.net/p/ryu/mailman/message/36260483/ .
This issue only happens when the agent is not able to establish a BGP session to the peer. When the BGP session is connected while the speaker is being removed, https://bugs.launchpad.net/bugs/1750383 is triggered instead.

A workaround might be to explicitly remove all peers (in the ryu driver) before shutting down the speaker, but I'd be fine with waiting for this to be fixed in ryu, too.