Reverse floating IP records are not removed when floating IP is deleted

Bug #1746627 reported by Sam Morrison
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Designate
Medium
Simon Leinen
neutron
Undecided
Unassigned

Bug Description

When I release/delete a floating IP from my project that has a corresponding FloatingIP PTR record the record is not deleted.

Steps to reproduce:

Assign a floating IP to my project
Set a PTR record on my floating IP using the reverse floating IP API
Release floatingIP

PTR record still exists in designate.

I have the sink running and this picks up the notification if you have the neutron_floatingip handler but this is for something else. I think this needs to be modified to also handle the reverse PTR records (managed_resource_type = ptr:floatingip)

Revision history for this message
Graham Hayes (grahamhayes) wrote :

We would need to add a new handler to listen to events and update the records.

This seems like a good idea.

summary: - Reverse floating IP records are removed when floating IP is deleted
+ Reverse floating IP records are not removed when floating IP is deleted
Changed in designate:
status: New → Triaged
importance: Undecided → Critical
importance: Critical → Medium
Changed in designate:
assignee: nobody → Simon Leinen (simon-leinen)
Revision history for this message
kiran pawar (kiranpawar89) wrote :

I am not able to reproduce this bug on devstack master
(designate commit e8c901c32318a4f6bec7cb4f6d95fcc48c57ad73)

openstack ptr record list <-------------------- Nothing shown
openstack floating ip create public
openstack server add floating ip INSTANCE_NAME_OR_ID FLOATING_IP_ADDRESS
openstack ptr record list <-------------------- one record shown
openstack ptr record show FLOATINGPOINT_ID
openstack ptr record set FLOATINGPOINT_ID ftp.example.com.
openstack ptr record unset FLOATINGPOINT_ID
openstack ptr record show FLOATINGPOINT_ID
openstack server remove floating ip INSTANCE_NAME_OR_ID FLOATING_IP_ADDRESS
openstack floating ip delete FLOATING_IP_ADDRESS
openstack ptr record list <-------------------- Nothing shown

Revision history for this message
Sam Morrison (sorrison) wrote :

Sorry been a while since I reported this and memory fading but it looks like you're unsetting the PTR manually and not replicating the bug?

The bug is that if I release a floating IP from my project then I'd expect the PTR record to also be deleted.

What if you change your steps to:

openstack ptr record list <-------------------- Nothing shown
openstack floating ip create public
openstack server add floating ip INSTANCE_NAME_OR_ID FLOATING_IP_ADDRESS
openstack ptr record list <-------------------- one record shown
openstack ptr record set FLOATINGPOINT_ID ftp.example.com.
openstack server remove floating ip INSTANCE_NAME_OR_ID FLOATING_IP_ADDRESS
openstack floating ip delete FLOATING_IP_ADDRESS
openstack ptr record list <-------------------- Still shown?

Revision history for this message
kiran pawar (kiranpawar89) wrote :

ok, I tried below (i.e. without unsetting)

 openstack zone create --email <email address hidden> example.org.
 openstack ptr record list <------- nothing shown
 openstack floating ip create public
 openstack ptr record list <---- one record shown
 openstack ptr record set RegionOne:8876c471-bd8e-4d00-bcca-2d7d05b4f165 ftp.example.org.
 openstack ptr record list <---- same record with updated ptrdname and ttl
 openstack floating ip delete 172.24.4.112
 openstack ptr record list <------- nothing shown

Revision history for this message
Sam Morrison (sorrison) wrote :

OK nice, so looks like this bug is fixed

Revision history for this message
kiran pawar (kiranpawar89) wrote :

No, there is another bug I believe.

 openstack floating ip delete 172.24.4.112
 openstack ptr record list <------- nothing shown

ptr record is deleted but recordset is not deleted. Executing below command after floating ip deletion shows PTR record (apart from default SOA and NS records)

openstack recordset list --all-projects 4.24.172.in-addr.arpa.

Is it mandatory to unset ptr record before floating ip deletion ?
OR
Neutron should handle deletion of PTR recordset entry even-if user did not unset ptr record ?

Revision history for this message
kiran pawar (kiranpawar89) wrote :

I have potential fix for problem mentioned in last comment, but its in neutron.

@sorrison Should we move bug to neutron and then create PR ?

Revision history for this message
kiran pawar (kiranpawar89) wrote :
Revision history for this message
Dr. Jens Harbott (j-harbott) wrote :

As I mentioned in the patch, combining neutron dns-integration with the designate PTR functionality is not supported, so if this is the issue, the bug is invalid. I actually think that we should deprecate and drop the designate support for that in order to avoid such conflicts.

Changed in neutron:
status: New → Invalid
Changed in neutron:
status: Invalid → In Progress
Revision history for this message
Slawek Kaplonski (slaweq) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in neutron:
status: In Progress → New
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/771556
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers