L3 service providers driver controller lacks sufficient notifications to enable L3 flavors

[Miguel Lavalle]

Notifications for l3 flavor for resource(ROUTER_CONTROLLER) and events(PRECOMMIT_ADD/DEL_ASSOCIATION) are needed so that l3 flavor drivers can subscribe to them

[Manjeet Singh Bhatia (manjeet-s-bhatia)]

thanks Miguel, really appreciate it.

[Miguel Lavalle (minsel)]

Patches are https://review.openstack.org/#/c/523257/ and https://review.openstack.org/#/c/532993/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/541766

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/541853

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/541853
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=31a3f2ff454cdbb1e1e3b69ec90611ba6ffdc903
Submitter: Zuul
Branch: master

commit 31a3f2ff454cdbb1e1e3b69ec90611ba6ffdc903
Author: Isaku Yamahata <email address hidden>
Date: Wed Feb 7 11:51:50 2018 -0800

    l3: don't begin db transaction in set_extra_attr_value

    As ExtraAttributesMixin.set_extra_attr_value() is assumed to be called
    by callback of PRECOMMIT. So there is no point to start nested
    transaction. So don't start transaction and check if transaction is
    already started.

    Change-Id: I0e2707222b1f91199cf466c997c0e691679fd3a4
    Partial-bug: #1745633

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/544817

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/544817
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=44b966837da4c4ce64eb5d02579ada65f062ac01
Submitter: Zuul
Branch: master

commit 44b966837da4c4ce64eb5d02579ada65f062ac01
Author: Isaku Yamahata <email address hidden>
Date: Wed Feb 14 23:25:40 2018 -0800

    l3: an unit test for set_extra_attr_value

    Add an unit test for set_extra_attr_value to check if
    exception is raised when it's called out of db transaction.
    This patch is follow up for I0e2707222b1f91199cf466c997c0e691679fd3a4

    Change-Id: I1c9bdf88ceba8ac07c8501b2f5590bc6adc6c337
    Partial-bug: #1745633

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/541766
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=217efe0a7ba192017612fffd99a16e50e1bd8b8e
Submitter: Zuul
Branch: master

commit 217efe0a7ba192017612fffd99a16e50e1bd8b8e
Author: Isaku Yamahata <email address hidden>
Date: Wed Feb 7 08:04:08 2018 -0800

    callback: priority to specify calling order

    Add priority to specify calling order.
    l3 flavor requires to enforce calling order which is discussed at
    https://review.openstack.org/#/c/523257/

    Co-Authored-By: Manjeet Singh Bhatia<email address hidden>

    Change-Id: Ib4fa951eabc184c9d175e32b1db4af68a836dc10
    Partial-bug: #1745633

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/523257
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b9fabd82675e2b74dd4afd3b7d1f8fbda6951ecd
Submitter: Zuul
Branch: master

commit b9fabd82675e2b74dd4afd3b7d1f8fbda6951ecd
Author: Isaku Yamahata <email address hidden>
Date: Mon Nov 27 16:42:29 2017 -0800

    l3 flavor: more events/notifications and callback priority

    After the addition of a new resource and related events with [1],
    this patch adds the necessary notifications for l3 flavor,
    resource(ROUTER_CONTROLLER) and events(PRECOMMIT_ADD_ASSOCIATION and
    PRECOMMIT_DELETE_ASSOCIATIONS) so that l3 flavor driver can subscribe to
    them when flavor is changed.

    Apply callback priority to ensure that the ordering of callback the
    following.
    - l3_*_db callbacks to extend l3 extended attributes
      This callbacks need to be called first so that rest callbacks can
      see those extended attributes.
    - l3 driver controller callbacks
    - l3 flavor driver callbacks
    extra routes/l3_gwmode/l3_hamode need care because they are
    updated via update_router but within different db transaction.

    [1] I1e72ee843851004d26410a90da4030ab3b024741

    Closes-Bug: #1745633

    Co-Authored-By: Manjeet Singh Bhatia<email address hidden>
    Change-Id: If20b11f0587f1ed30db72d97c15b20d4c6e87543
    Depends-On: https://review.openstack.org/#/c/541766/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/591673

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kailun Qin (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/591673