Avoid mixed usage of old and new transaction styles
Bug #1744829 reported by
Lujin Luo
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
High
|
Lujin Luo |
Bug Description
The newly merged (distributed) Port Binding OVO integration patch [1] is mixing the old nested transaction style used by OVO with the new engine facade transactions. According to what we learnt in https:/
A patch to change the new engine facade transactions back to old nested transaction style is required.
Changed in neutron: | |
assignee: | nobody → Lujin Luo (luo-lujin) |
Changed in neutron: | |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in neutron: | |
status: | Confirmed → In Progress |
Changed in neutron: | |
milestone: | none → queens-rc1 |
Changed in neutron: | |
status: | In Progress → Fix Committed |
Changed in neutron: | |
status: | Fix Committed → Fix Released |
tags: | added: neutron-proactive-backport-potential |
tags: | removed: neutron-proactive-backport-potential |
To post a comment you must log in.
Lujin Luo,
Thanks for filing this bug. Per our conversation in IRC of moments ago, while we need to fix the specific buggy code introduced by https:/ /review. openstack. org/#/c/ 407868, we also need to think about some follow up questions:
1) Is it better for our users a ML2 plugin with OVO for port bindings and old engine facade than the one we had before with new engine facade and old style DB code?
2) In the longer term, does this mean that every time we adopt OVO in a piece of code, we are going to undo the good work done in adopting the new engine facade?
Both OVO and the new engine facade are good things that we certainly want to adopt in Neutron. We are painting ourselves into a corner where we have to choose between one or the other. I pinged Matt Riedemann earlier today and asked him about Nova's adoption of new engine facade and OVO. It is complete and they co-exist nicely. This event should prompt us to think how we can get Neutron in the same position. I think this should be a topic that we discuss in Dublin and put together a solid plan to move ahead with both OVO and new engine facade