Dynamic routing: invalid exception inputs leads to test exceptions

[Gary Kotton]

Unit tests have exceptions:

Exception encountered during bgp_speaker rescheduling.
Traceback (most recent call last):
  File "/home/gkotton/neutron-dynamic-routing/.tox/py27/src/neutron/neutron/db/agentschedulers_db.py", line 159, in reschedule_resources_from_down_agents
    reschedule_resource(context, binding_resource_id)
  File "neutron_dynamic_routing/db/bgp_dragentscheduler_db.py", line 174, in reschedule_bgp_speaker
    failure_reason="no eligible dr agent found")
TypeError: __init__() got an unexpected keyword argument 'failure_reason'
BgpDrAgent 84dfa040-c1d4-40b1-8a16-0502ffccbb5b is down

The tests pass but this will lead to extra failures in the real worl

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/529007

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/550000

[OpenStack Infra (hudson-openstack)]

Change abandoned by garyk (<email address hidden>) on branch: master
Review: https://review.openstack.org/529007
Reason: Going with the other patch. Which is exactly the same. But lets at least resolve the issue

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550000
Committed: https://git.openstack.org/cgit/openstack/neutron-dynamic-routing/commit/?id=39d9d0de9e13077431243f898022c1aa11b8ef64
Submitter: Zuul
Branch: master

commit 39d9d0de9e13077431243f898022c1aa11b8ef64
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Mar 6 19:14:38 2018 +0900

    Fix TypeError for BgpSpeakerRescheduleError

    Inherit Conflicts to be consistent with RouterReschedulingFailed.

    Closes-Bug: #1738983
    Change-Id: If2d6151c161d1b0848ecb28bdb823676249e1221

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 13.0.0.0b1 development milestone.