neutron-lib: bogus error when OVO primary key missing

[Thomas Morin]

I see the following in logs:

Dec 13 11:39:27.531721 ubuntu-xenial-rax-iad-0001416544 neutron-server[5115]: ERROR networking_bgpvpn.neutron.services.service_drivers.bagpipe.bagpipe NeutronPrimaryKeyMissing: For class str missing primary keys: set(['network_id'])

The 'for class str' is bogus, and seems to be due to the fact that at [1] we have

            raise o_exc.NeutronPrimaryKeyMissing(object_class=cls.__name__,
                                                 missing_keys=missing_keys)

instead of

            raise o_exc.NeutronPrimaryKeyMissing(object_class=cls,
                                                 missing_keys=missing_keys)

[1] https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L514

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/527725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/527725
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d198d71ffda41fb0e49eed3c6afb9642ed54356a
Submitter: Zuul
Branch: master

commit d198d71ffda41fb0e49eed3c6afb9642ed54356a
Author: Thomas Morin <email address hidden>
Date: Wed Dec 13 16:53:02 2017 +0100

    Fix NeutronPrimaryKeyMissing instantiation

    Change-Id: I6749b97c568bbf49df4a386825f80d61aa34a685
    Closes-Bug: 1738023

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.0.0b3 development milestone.