No create_precommit callback notification for floating ips

[Lucas Alvares Gomes]

It's possible today to subscribe to a create_precommit callback in neutron for floating ips today but, that notification will never get sent because it's missing the notify() call in the Neutron code [0].

As a context, networking-ovn is planning to use the precommit() callbacks for the database consistency work that is being described at [1]

[0] https://github.com/openstack/neutron/blob/acef6d1666336cd4846675572043d95c06cd2267/neutron/db/l3_db.py#L1253-L1338

[1] https://review.openstack.org/#/c/490834/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/525254

[Brian Haley (brian-haley)]

I'm confused myself after looking at the code, as _create_floatingip() issues an AFTER_UPDATE when done, seems like that should even be an AFTER_CREATE ? But then I guess the DVR code - _create_dvr_floating_gw_port(), would need to subscribe to that as well, it only receives AFTER_UPDATE.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/525254
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=98dfdc24bb7ee13b25766231bdb44caf8ff63766
Submitter: Zuul
Branch: master

commit 98dfdc24bb7ee13b25766231bdb44caf8ff63766
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Dec 4 17:01:54 2017 +0000

    Add CREATE_PRECOMMIT notification for Floating IPs

    This patch is adding a CREATE_PRECOMMIT notification for floating ips.
    Before it was possible to register a callback for that (no errors) but
    the notification would never be sent because the code was simple not in
    place.

    Closes-Bug: #1736201
    Change-Id: If901d4d54118a6343597ab2ad075b6a2399ea62c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.0.0b2 development milestone.