DVR lost centralized floating ip when the ha state switched.

[sunzuohua]

Reproduction steps:
The l3 agent mode is as follows:
    Network:dvr_snat
    Compute:dvr_no_external
1、Create a DVR(HA). Then add interface and gateway to the DVR.
2、Create a vm and associate a floating ip to the vm.
3、Check the keepalived.conf and snat ns on the master and backup network nodes for the DVR.
4、The floating ip can be found in the keepalived.conf on the master network node but not in the keepalived.conf on the backup network node for the DVR .On the master network node for the DVR , the floating ip is found normal in the snat ns.
5.Swith the ha state of the DVR, Check the keepalived.conf and snat ns on the current master network node for the DVR.
6.The floating ip still can not be found in the keepalived.conf on the current master network node. And on the current master network node for the DVR , the floating ip is not found in the snat ns.

Mybe the check for the router ha state[1] should be moved just before [2].

[1]https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_edge_ha_router.py#L61
[2]https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_edge_ha_router.py#L65

[Swaminathan Vasudevan (swaminathan-vasudevan)]

So when the check for the router ha state[1] moved to [2] is that working as designed? Meanwhile I will take a look at it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/525842

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/525842
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2200b1c3697a478af9f25a20ce09564bc2c9a968
Submitter: Zuul
Branch: master

commit 2200b1c3697a478af9f25a20ce09564bc2c9a968
Author: zhsun <email address hidden>
Date: Wed Dec 6 08:53:55 2017 +0800

    Add/rm centralized fips for DVR+HA from standby node

    For DVR+HA:
    When adding/removing a centralized fip, just add/remove it to/from
    keepalived instance and do not check if it is a master router.

    When adding a centralized fip, it is still needed to invoke method
    of supperclass to configure nat rules on master node.

    When removing a centralized fip, it is still needed to invoke method
    of supperclass to clean contrack on master node.

    Change-Id: I202db59acb7fb0b7924748cf7def2879a748e56a
    Closes-Bug: #1736068

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/575689

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/575690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/575690
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5e967131eec7035a019adaa93284f16830faf510
Submitter: Zuul
Branch: stable/pike

commit 5e967131eec7035a019adaa93284f16830faf510
Author: zhsun <email address hidden>
Date: Wed Dec 6 08:53:55 2017 +0800

    Add/rm centralized fips for DVR+HA from standby node

    For DVR+HA:
    When adding/removing a centralized fip, just add/remove it to/from
    keepalived instance and do not check if it is a master router.

    When adding a centralized fip, it is still needed to invoke method
    of supperclass to configure nat rules on master node.

    When removing a centralized fip, it is still needed to invoke method
    of supperclass to clean contrack on master node.

    Change-Id: I202db59acb7fb0b7924748cf7def2879a748e56a
    Closes-Bug: #1736068
    (cherry picked from commit 2200b1c3697a478af9f25a20ce09564bc2c9a968)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/575689
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e3d11d45cfeba2ac4e3bcef2508522e599a0c494
Submitter: Zuul
Branch: stable/queens

commit e3d11d45cfeba2ac4e3bcef2508522e599a0c494
Author: zhsun <email address hidden>
Date: Wed Dec 6 08:53:55 2017 +0800

    Add/rm centralized fips for DVR+HA from standby node

    For DVR+HA:
    When adding/removing a centralized fip, just add/remove it to/from
    keepalived instance and do not check if it is a master router.

    When adding a centralized fip, it is still needed to invoke method
    of supperclass to configure nat rules on master node.

    When removing a centralized fip, it is still needed to invoke method
    of supperclass to clean contrack on master node.

    Change-Id: I202db59acb7fb0b7924748cf7def2879a748e56a
    Closes-Bug: #1736068
    (cherry picked from commit 2200b1c3697a478af9f25a20ce09564bc2c9a968)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.6 release.