[RFE] Add new admin_state_up option 'auto' for SR-IOV VF port

Bug #1722720 reported by Peng Liu
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Hongbin Lu

Bug Description

Currently, there are only 2 options True/False for port attribute 'admin_state_up', underneath they are mapped to 'ip link set <dev> enable/disable'. However, in case of SR-IOV VF port the state can be set to 'auto', which means the VF link state can follow that of PF. When PF link goes down, VF link state will go down as well. And this functionality is useful when the VMs use the link state as a trigger of its own HA mechanism.

Therefore the expected change is to add a 3rd option admin_state_up 'auto' for neutron SR-IOV VF port.

Revision history for this message
Jakub Libosvar (libosvar) wrote :

There has been added a port data plane status - https://specs.openstack.org/openstack/neutron-specs/specs/pike/port-data-plane-status.html

Can you please have a look whether using this attribute for HA mechanism instead would solve your problem?

Changed in neutron:
importance: Undecided → Wishlist
tags: added: sriov-pci-pt
Revision history for this message
Peng Liu (pliu) wrote :

That could be an approach. But it needs a SDN controller or other external component to monitor/set the date-plane-status, and also it takes more time to process the failure event. Comparing to that, letting the VF follow the status of PF seems a more straightforward way. Is there any drawback for adding the 'auto' as an option of admin_state_up only for SRIOV VF port?

hongbin (hongbin034)
Changed in neutron:
assignee: nobody → hongbin (hongbin034)
assignee: hongbin (hongbin034) → nobody
Hongbin Lu (hongbin.lu)
Changed in neutron:
assignee: nobody → Hongbin Lu (hongbin.lu)
Miguel Lavalle (minsel)
tags: added: rfe
Hongbin Lu (hongbin.lu)
Changed in neutron:
assignee: Hongbin Lu (hongbin.lu) → nobody
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :

I'd use a separate attribute for this (like propagate_uplink_status ? or something like that), It's not admin state itself (which is something that the admin enforces).

This could be reused also for trunk/subports.

Hongbin Lu (hongbin.lu)
Changed in neutron:
assignee: nobody → Hongbin Lu (hongbin.lu)
Revision history for this message
Miguel Lavalle (minsel) wrote :

This RFE was approved in Dublin. Please see "ML2 and Mechanism drivers", first bullet in the Dublin PTG summary: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128183.html

tags: added: rfe-approved
removed: rfe
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/571821

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/571899

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/571821
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=1f7d11cd9fcb1bb8a62dbce8951569b1147987c6
Submitter: Zuul
Branch: master

commit 1f7d11cd9fcb1bb8a62dbce8951569b1147987c6
Author: Hongbin Lu <email address hidden>
Date: Fri Jun 1 20:28:47 2018 +0000

    Add attribute propagate_uplink_status to port

    This attribute indicates if the state of the port will follow
    the state of its parent port. The first use case of this attribute
    is SR-IOV. If it is a VF port, setting this attribute can make
    the VF link state follow the state of the PF. In the future,
    this attribute might be reused for trunk/subports as well.

    Change-Id: If622b8df6b890530adace4821a6408ef942cc80a
    Partial-Bug: #1722720

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/620425

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Hongbin Lu (<email address hidden>) on branch: master
Review: https://review.openstack.org/620425
Reason: I have to re-spin the parent patch (https://review.openstack.org/#/c/571899/) so I incorporate releasenote there and drop this patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/571899
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f0678b9b0965dae1ab340cd7dd9805eca1ea6e7f
Submitter: Zuul
Branch: master

commit f0678b9b0965dae1ab340cd7dd9805eca1ea6e7f
Author: Hongbin Lu <email address hidden>
Date: Fri Jun 1 22:46:52 2018 +0000

    Add propagate_uplink_status to port

    Introduce an attribute 'propagate_uplink_status' to port.
    This attribute can be implemented for VF port to indicate if the VF
    link state should follow the state of the PF.

    Note: ML2 extension driver loaded on request via configuration:

      [ml2]
      extension_drivers = uplink_status_propagation

    Other related patches:
    * neutron-lib: https://review.openstack.org/#/c/571821/
    * tempest test: https://review.openstack.org/#/c/586719/
    * OSC: https://review.openstack.org/#/c/586684/
    * neutronclient: https://review.openstack.org/#/c/586712/

    APIImpact Add 'propagate_uplink_status' attribute to 'port' resource

    Change-Id: Ie8260c332e24c1880f9f82e6b6dacca8415be842
    Close-Bug: #1722720

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-tempest-plugin (master)

Reviewed: https://review.openstack.org/586719
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=5da7333450dcee518b43bddb755d579e34bf271d
Submitter: Zuul
Branch: master

commit 5da7333450dcee518b43bddb755d579e34bf271d
Author: Hongbin Lu <email address hidden>
Date: Fri Jul 27 22:34:59 2018 +0000

    Test propagate_uplink_status on create port

    Depends-On: Ie8260c332e24c1880f9f82e6b6dacca8415be842
    Change-Id: Iffffb177990c8f615d962ad35b58ecf425143e37
    Related-Bug: #1722720

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lib (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/623251

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/623251
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=100f842cdf82355f3d597e955e8fc17f7ef4fbe8
Submitter: Zuul
Branch: master

commit 100f842cdf82355f3d597e955e8fc17f7ef4fbe8
Author: Hongbin Lu <email address hidden>
Date: Thu Dec 6 16:36:44 2018 +0000

    api-ref: document uplink status propagation

    Neutron patch: https://review.openstack.org/#/c/571899/

    Change-Id: I07bd7fa2b048280a5a441533d780a8ede790a834
    Related-Bug: #1722720

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.