Unnecessary notification when notify_sg_on_port_change

Bug #1720322 reported by Jesse on 2017-09-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Jesse

Bug Description

In this patch: https://review.openstack.org/#/c/435601
It added notify_sg_on_port_change when any port attributes update. This will cause unnecessary notification to neutron-l2-agents when port update, for example like port's name update.
notify_sg_on_port_change will only needed when port's Security Group update or port IP change, and this has done in codes: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L1405

Jesse (jesse-5) on 2017-09-29
summary: - Port updating wrongly notify_security_groups_member_updated
+ Unnecessary notification when notify_sg_on_port_change

Fix proposed to branch: master
Review: https://review.openstack.org/508446

Changed in neutron:
assignee: nobody → Jesse (jesse-5)
status: New → In Progress
Miguel Lavalle (minsel) on 2017-10-04
Changed in neutron:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/508446
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=530d97141acb63dfe02566bda0a7e78fb058b6b0
Submitter: Zuul
Branch: master

commit 530d97141acb63dfe02566bda0a7e78fb058b6b0
Author: jufeng <email address hidden>
Date: Fri Sep 29 16:38:24 2017 +0800

    Fix unnecessary security_groups_member_updated notification

    notify_sg_on_port_change will cause unnecessary notification to
    neutron-l2-agents when port update, for example like port's name
    updating will also notify.

    notify_sg_on_port_change will only be needed when port's
    Security Group update or port IP change.

    Change-Id: I5439adf2c4b7dcf832241201fd949f6930e65fdf
    Closes-Bug: #1720322

Changed in neutron:
status: In Progress → Fix Released

This issue was fixed in the openstack/neutron 13.0.0.0b1 development milestone.

Reviewed: https://review.opendev.org/749447
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=53de19cc3cfd65b8650287ca49b2933494aa1e57
Submitter: Zuul
Branch: stable/queens

commit 53de19cc3cfd65b8650287ca49b2933494aa1e57
Author: jufeng <email address hidden>
Date: Fri Sep 29 16:38:24 2017 +0800

    Fix unnecessary security_groups_member_updated notification

    notify_sg_on_port_change will cause unnecessary notification to
    neutron-l2-agents when port update, for example like port's name
    updating will also notify.

    notify_sg_on_port_change will only be needed when port's
    Security Group update or port IP change.

    Change-Id: I5439adf2c4b7dcf832241201fd949f6930e65fdf
    Closes-Bug: #1720322
    (cherry picked from commit 530d97141acb63dfe02566bda0a7e78fb058b6b0)

tags: added: in-stable-queens
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers