When create a fip with subnet_id and ip specified, the created fip won't be the ip specified

[Yang Li]

When create a fip with subnet_id and ip option specified, the created fip won't be the ip specified, in the original code, it will be replaced with subnet_id, and it will confuse users.For example:

#neutron floatingip-create --floating-ip-address 10.10.0.10 --subnet <subnet_id> <network>
then 10.10.0.2 was allocated, not 10.10.0.10

If only floating-ip-address is specified, the result is fine
#neutron floatingip-create --floating-ip-address 10.10.0.10 <network>
then 10.10.0.10 was allocated

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/589030

[OpenStack Infra (hudson-openstack)]

Change abandoned by Li Zhouzhou (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/589030

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/506532
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brian Haley (<email address hidden>) on branch: master
Review: https://review.opendev.org/506532
Reason: Already fixed in https://review.opendev.org/#/c/528535/

[Brian Haley (brian-haley)]

This was fixed in https://review.opendev.org/#/c/528535/