ml2_distributed_port_bindings not cleared after migration from DVR

Bug #1718345 reported by venkata anil
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Brian Haley

Bug Description

When a router is migrated from DVR to HA/legacy, router interface bindings in ml2_distributed_port_bindings table not cleared and still exist after the migration.

Also when a DVR router is removed from a agent, still it's entry for that agent existins in ml2_distributed_port_bindings.

Changed in neutron:
assignee: nobody → venkata anil (anil-venkata)
Revision history for this message
Swaminathan Vasudevan (swaminathan-vasudevan) wrote :

So it seems that this is a new bug related to the Migration where the port-binding table is not cleared.

description: updated
tags: added: l3-dvr-backlog
tags: added: l3-ha
Changed in neutron:
assignee: venkata anil (anil-venkata) → nobody
Revision history for this message
Swaminathan Vasudevan (swaminathan-vasudevan) wrote :

@anil-venkata where is your code calling to clean up the ml2_distributed_port_bindings.
In the case of dvr the ml2_distributed_port_bindings are called in ensure_port_bindings are set for the ports.
So might be when you migrate the routers, we should probably call the respective code to clean up.

Revision history for this message
Swaminathan Vasudevan (swaminathan-vasudevan) wrote :

yes the port-binding table is not cleared.
This is confirmed.

Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Swaminathan Vasudevan (swaminathan-vasudevan) wrote :

@anil-venkata I did notice that when a DVR router is migrated to a CVR router, the device_owner: of the router-interface is changed from router-interface-distributed to 'network:ha_router_replicated_interface', even though Router HA is not enabled.
Should it not be just 'router_interface'.

Changed in neutron:
assignee: nobody → Swaminathan Vasudevan (swaminathan-vasudevan)
status: Confirmed → In Progress
Revision history for this message
Slawek Kaplonski (slaweq) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in neutron:
assignee: Swaminathan Vasudevan (swaminathan-vasudevan) → nobody
status: In Progress → New
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/508808
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
assignee: nobody → Brian Haley (brian-haley)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/508808
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=32bfc3edeca935fc9c16b3019aa0af3091cd19e7
Submitter: Zuul
Branch: master

commit 32bfc3edeca935fc9c16b3019aa0af3091cd19e7
Author: Swaminathan Vasudevan <email address hidden>
Date: Sun Oct 1 23:27:29 2017 -0700

    DVR: Cleanup ml2 dvr portbindings on migration

    When a DVR router is migrated from distributed to
    centralized, we are unbinding the router from the
    agents, but the ml2 distributed portbindings for
    the router port still remains intact.

    This patch will fix the issue by deleting the
    binding entry for multiple hosts.

    Closes-Bug: #1718345
    Change-Id: If139790eb336ff13b07b094151946af30322ad3e

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.0.0.0b1

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/685173

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/685174

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/stein)

Reviewed: https://review.opendev.org/685173
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=add87accc5105124241042a5f0933b76e93648f4
Submitter: Zuul
Branch: stable/stein

commit add87accc5105124241042a5f0933b76e93648f4
Author: Swaminathan Vasudevan <email address hidden>
Date: Sun Oct 1 23:27:29 2017 -0700

    DVR: Cleanup ml2 dvr portbindings on migration

    When a DVR router is migrated from distributed to
    centralized, we are unbinding the router from the
    agents, but the ml2 distributed portbindings for
    the router port still remains intact.

    This patch will fix the issue by deleting the
    binding entry for multiple hosts.

    Closes-Bug: #1718345
    Change-Id: If139790eb336ff13b07b094151946af30322ad3e
    (cherry picked from commit 32bfc3edeca935fc9c16b3019aa0af3091cd19e7)

tags: added: in-stable-stein
tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.opendev.org/685174
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8bda3c2ed33906ab2fbacc23f5775b4e0f4b76b0
Submitter: Zuul
Branch: stable/rocky

commit 8bda3c2ed33906ab2fbacc23f5775b4e0f4b76b0
Author: Swaminathan Vasudevan <email address hidden>
Date: Sun Oct 1 23:27:29 2017 -0700

    DVR: Cleanup ml2 dvr portbindings on migration

    When a DVR router is migrated from distributed to
    centralized, we are unbinding the router from the
    agents, but the ml2 distributed portbindings for
    the router port still remains intact.

    This patch will fix the issue by deleting the
    binding entry for multiple hosts.

    Closes-Bug: #1718345
    Change-Id: If139790eb336ff13b07b094151946af30322ad3e
    (cherry picked from commit 32bfc3edeca935fc9c16b3019aa0af3091cd19e7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.3

This issue was fixed in the openstack/neutron 14.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.5

This issue was fixed in the openstack/neutron 13.0.5 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers