ml2_distributed_port_bindings not cleared after migration from DVR

[venkata anil]

When a router is migrated from DVR to HA/legacy, router interface bindings in ml2_distributed_port_bindings table not cleared and still exist after the migration.

Also when a DVR router is removed from a agent, still it's entry for that agent existins in ml2_distributed_port_bindings.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

So it seems that this is a new bug related to the Migration where the port-binding table is not cleared.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

@anil-venkata where is your code calling to clean up the ml2_distributed_port_bindings.
In the case of dvr the ml2_distributed_port_bindings are called in ensure_port_bindings are set for the ports.
So might be when you migrate the routers, we should probably call the respective code to clean up.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

yes the port-binding table is not cleared.
This is confirmed.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

@anil-venkata I did notice that when a DVR router is migrated to a CVR router, the device_owner: of the router-interface is changed from router-interface-distributed to 'network:ha_router_replicated_interface', even though Router HA is not enabled.
Should it not be just 'router_interface'.

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/508808
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/508808
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=32bfc3edeca935fc9c16b3019aa0af3091cd19e7
Submitter: Zuul
Branch: master

commit 32bfc3edeca935fc9c16b3019aa0af3091cd19e7
Author: Swaminathan Vasudevan <email address hidden>
Date: Sun Oct 1 23:27:29 2017 -0700

    DVR: Cleanup ml2 dvr portbindings on migration

    When a DVR router is migrated from distributed to
    centralized, we are unbinding the router from the
    agents, but the ml2 distributed portbindings for
    the router port still remains intact.

    This patch will fix the issue by deleting the
    binding entry for multiple hosts.

    Closes-Bug: #1718345
    Change-Id: If139790eb336ff13b07b094151946af30322ad3e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/685173

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/685174

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685173
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=add87accc5105124241042a5f0933b76e93648f4
Submitter: Zuul
Branch: stable/stein

commit add87accc5105124241042a5f0933b76e93648f4
Author: Swaminathan Vasudevan <email address hidden>
Date: Sun Oct 1 23:27:29 2017 -0700

    DVR: Cleanup ml2 dvr portbindings on migration

    When a DVR router is migrated from distributed to
    centralized, we are unbinding the router from the
    agents, but the ml2 distributed portbindings for
    the router port still remains intact.

    This patch will fix the issue by deleting the
    binding entry for multiple hosts.

    Closes-Bug: #1718345
    Change-Id: If139790eb336ff13b07b094151946af30322ad3e
    (cherry picked from commit 32bfc3edeca935fc9c16b3019aa0af3091cd19e7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685174
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8bda3c2ed33906ab2fbacc23f5775b4e0f4b76b0
Submitter: Zuul
Branch: stable/rocky

commit 8bda3c2ed33906ab2fbacc23f5775b4e0f4b76b0
Author: Swaminathan Vasudevan <email address hidden>
Date: Sun Oct 1 23:27:29 2017 -0700

    DVR: Cleanup ml2 dvr portbindings on migration

    When a DVR router is migrated from distributed to
    centralized, we are unbinding the router from the
    agents, but the ml2 distributed portbindings for
    the router port still remains intact.

    This patch will fix the issue by deleting the
    binding entry for multiple hosts.

    Closes-Bug: #1718345
    Change-Id: If139790eb336ff13b07b094151946af30322ad3e
    (cherry picked from commit 32bfc3edeca935fc9c16b3019aa0af3091cd19e7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.5 release.