_ensure_vr_id_and_network is not used anywhere in the code

[venkata anil]

_ensure_vr_id_and_network is not used anywhere in the code, hence can be removed.

[Christopher Brown (snecklifter)]

[cbrown2@flash neutron]$ grep -ir "_ensure_vr_id_and_network" *
neutron/tests/unit/db/test_l3_hamode_db.py: net = self.plugin._ensure_vr_id_and_network(
neutron/tests/unit/db/test_l3_hamode_db.py: def test_ensure_vr_id_and_network_net_exists(self):
neutron/tests/unit/db/test_l3_hamode_db.py: self.plugin._ensure_vr_id_and_network(
neutron/tests/unit/db/test_l3_hamode_db.py: def test_ensure_vr_id_and_network_concurrent_create(self):
neutron/tests/unit/db/test_l3_hamode_db.py: net = self.plugin._ensure_vr_id_and_network(
neutron/tests/unit/db/test_l3_hamode_db.py: self.plugin._ensure_vr_id_and_network(
neutron/tests/unit/db/test_l3_hamode_db.py: def test_ensure_vr_id_and_network_interface_failure(self):
neutron/tests/unit/db/test_l3_hamode_db.py: def test_ensure_vr_id_and_network_concurrent_delete(self):
neutron/tests/unit/db/test_l3_hamode_db.py: def test_ensure_vr_id_and_network_concurrent_swap(self):
neutron/db/l3_hamode_db.py: def _ensure_vr_id_and_network(self, context, router_db):

Would you like me to prep a patch which removes this ^^^ ?

[Sapna Jadhav (sapana45)]

Hi all,
Is this bug still valid? If yes then I would like to work on this.
Shall I remove _ensure_vr_id_and_network from the code?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/784572
Committed: https://opendev.org/openstack/neutron/commit/ba3d78099f47c3819af0f6eb2083a1df7f67c38d
Submitter: "Zuul (22348)"
Branch: master

commit ba3d78099f47c3819af0f6eb2083a1df7f67c38d
Author: Nurmatov Mamatisa <email address hidden>
Date: Fri Apr 2 17:07:16 2021 +0300

    Remove unused method _ensure_vr_id_and_network()

    Method _ensure_vr_id_and_network is not used in l3_hamode_db.py,
    hence method and related tests can be removed.

    Closes-Bug: #1715371
    Change-Id: I9a64e683f060573195a88b3c4ee34abbd941fa44

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.