neutron

Pecan is missing some quota dirtying and resync calls

Bug #1714389 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton

Bug Description

The legacy API controller would resync and dirty the quotas at particular intervals that pecan is missing. In particular it would resync on GET operations[1] and dirty on deletes[2]. The pecan hook is missing both of these cases.

1. https://github.com/openstack/neutron/blob/8d2c1bd88b14eefbea74c72f384cb9952e7ee62e/neutron/api/v2/base.py#L338-L339
2. https://github.com/openstack/neutron/blob/8d2c1bd88b14eefbea74c72f384cb9952e7ee62e/neutron/api/v2/base.py#L589-L591

Kevin Benton (kevinbenton)
Changed in neutron:
importance: Undecided → High
OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/499434
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e76a575b0570880d4209ff1ea73f82c01e4a6e24
Submitter: Jenkins
Branch: master

commit e76a575b0570880d4209ff1ea73f82c01e4a6e24
Author: Kevin Benton <email address hidden>
Date: Wed Aug 30 20:16:59 2017 -0700

    Pecan: add calls to resync/dirty quota usages

    Add calls to dirty and resync the quota engine during
    DELETEs and GETs respectively. This matches the old API controller
    behavior and will be covered when the unit tests are switched to
    use pecan in [1].

    1. I76dc23fb7b96d82b0da50285bd0aac76142e81e5

    Closes-Bug: #1714389
    Change-Id: I1fb6b471e0e7cbf9b10dd14233931be94af38a41

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/502977

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.openstack.org/502977
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=be034640f1e83faf5eb546e6290627b72f8a0f3f
Submitter: Jenkins
Branch: stable/pike

commit be034640f1e83faf5eb546e6290627b72f8a0f3f
Author: Kevin Benton <email address hidden>
Date: Wed Aug 30 20:16:59 2017 -0700

    Pecan: add calls to resync/dirty quota usages

    Add calls to dirty and resync the quota engine during
    DELETEs and GETs respectively. This matches the old API controller
    behavior and will be covered when the unit tests are switched to
    use pecan in [1].

    1. I76dc23fb7b96d82b0da50285bd0aac76142e81e5

    Closes-Bug: #1714389
    Change-Id: I1fb6b471e0e7cbf9b10dd14233931be94af38a41
    (cherry picked from commit e76a575b0570880d4209ff1ea73f82c01e4a6e24)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.1

This issue was fixed in the openstack/neutron 11.0.1 release.

Ihar Hrachyshka (ihar-hrachyshka)
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.0.0b1

This issue was fixed in the openstack/neutron 12.0.0.0b1 development milestone.

Bernard Cafarelli (bcafarel)
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.