Pecan is missing logic to add project_id to fields when tenant_id is specified

Bug #1714378 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton

Bug Description

Pecan is missing this logic in the old controller code that adds 'tenant_id' to the filters required by the policy engine when the 'project_id' field is specified: https://github.com/openstack/neutron/blob/8d2c1bd88b14eefbea74c72f384cb9952e7ee62e/neutron/api/v2/base.py#L96

This is necessary when tenants request that only the tenant_id field is returned and we have a new class of resource that has a project_id field only.

Changed in neutron:
importance: Undecided → High
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/499429
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bf36f8c934b49310103a1b1831c9f7c8a0d14adf
Submitter: Jenkins
Branch: master

commit bf36f8c934b49310103a1b1831c9f7c8a0d14adf
Author: Kevin Benton <email address hidden>
Date: Wed Aug 30 20:05:30 2017 -0700

    Pecan: set tenant_id field when project_id set

    Add logic to pecan to add 'project_id' as a mandatory policy
    field whenever 'tenant_id' is specified as a policy field.
    This logic was added to the previous controller code to ensure
    that 'project_id' was queried in the database whenever 'tenant_id'
    was required by the policy engine and the user had fields set.

    Closes-Bug: #1714378
    Change-Id: I3652fbc50ce0c9a7cd1cc193e0933cf0373ecb54

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501222

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.openstack.org/501222
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8c74536b1eb9a2f696b547382f8c536151167dc7
Submitter: Jenkins
Branch: stable/pike

commit 8c74536b1eb9a2f696b547382f8c536151167dc7
Author: Kevin Benton <email address hidden>
Date: Wed Aug 30 20:05:30 2017 -0700

    Pecan: set tenant_id field when project_id set

    Add logic to pecan to add 'project_id' as a mandatory policy
    field whenever 'tenant_id' is specified as a policy field.
    This logic was added to the previous controller code to ensure
    that 'project_id' was queried in the database whenever 'tenant_id'
    was required by the policy engine and the user had fields set.

    Closes-Bug: #1714378
    Change-Id: I3652fbc50ce0c9a7cd1cc193e0933cf0373ecb54
    (cherry picked from commit bf36f8c934b49310103a1b1831c9f7c8a0d14adf)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.1

This issue was fixed in the openstack/neutron 11.0.1 release.

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.0.0b1

This issue was fixed in the openstack/neutron 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.