neutron

pecan hooks break on pagination + ID filter

Bug #1714131 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton

Bug Description

The user filters are applied to the results before pagination in the pecan hook pipeline so if the user filters out the ID field, the pagination code will throw an exception trying to build the next link.

Kevin Benton (kevinbenton)
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/499426

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/499426
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=41e6f02bf253e82fcc4baf4b77795ad831b58b43
Submitter: Jenkins
Branch: master

commit 41e6f02bf253e82fcc4baf4b77795ad831b58b43
Author: Kevin Benton <email address hidden>
Date: Wed Aug 30 19:46:39 2017 -0700

    Pecan: process filters at end of hook pipeline

    Separate user-applied filters from policy-enforcement
    filters processing and put it at the end of the pipeline
    so users can't put filters on the API request that impact
    the fields available to the hooks.

    This prevents a filter excluding the ID field from breaking
    pagination.

    Change-Id: I05f4582fb1e8809740d473e24fa54483e040a6c8
    Closes-Bug: #1714131

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501221

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.openstack.org/501221
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=624dbfcfb246bf92d2e0ce41019a8ca4b5ccbe4b
Submitter: Jenkins
Branch: stable/pike

commit 624dbfcfb246bf92d2e0ce41019a8ca4b5ccbe4b
Author: Kevin Benton <email address hidden>
Date: Wed Aug 30 19:46:39 2017 -0700

    Pecan: process filters at end of hook pipeline

    Separate user-applied filters from policy-enforcement
    filters processing and put it at the end of the pipeline
    so users can't put filters on the API request that impact
    the fields available to the hooks.

    This prevents a filter excluding the ID field from breaking
    pagination.

    Change-Id: I05f4582fb1e8809740d473e24fa54483e040a6c8
    Closes-Bug: #1714131
    (cherry picked from commit 41e6f02bf253e82fcc4baf4b77795ad831b58b43)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.1

This issue was fixed in the openstack/neutron 11.0.1 release.

Ihar Hrachyshka (ihar-hrachyshka)
tags: added: neutron-proactive-backport-potential
Jakub Libosvar (libosvar)
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.0.0b1

This issue was fixed in the openstack/neutron 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.