Update DVR router port cause error with QoS rules

[Slawek Kaplonski]

Update of "network:router_interface_distributed" ports cause problems with delete QoS bandwidth limit rules. It can be observed in logs like: http://logs.openstack.org/09/497009/4/check/gate-tempest-dsvm-neutron-dvr-multinode-scenario-ubuntu-xenial-nv/eed6c25/logs/screen-q-agt.txt.gz?level=TRACE

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/498598

[Swaminathan Vasudevan (swaminathan-vasudevan)]

Can you elaborate on the use case here and how to reproduce the problem.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

Is this only seen with DVR routers and not with legacy routers.

[Ihar Hrachyshka (ihar-hrachyshka)]

I don't think it's DVR only. Any port without a policy may be affected.

[Slawek Kaplonski (slaweq)]

Exactly as Ihar said but also only for ports which interface in ovs was already removed for some reason.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498598
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=46289c3c74bfa6ce258067026b54fa9887e3a942
Submitter: Jenkins
Branch: master

commit 46289c3c74bfa6ce258067026b54fa9887e3a942
Author: Sławek Kapłoński <email address hidden>
Date: Mon Aug 28 20:59:12 2017 +0000

    Fix cleaning QoS rules for not existing port.

    If port update event is received by L2 agent and there is
    no QoS policy assigned to such port, agent tries to delete
    any existing QoS rules from port.
    For bandwidth limit rules OVS qos driver tries to update
    port in OVS database.
    In case if port not exists in OVS database agent raised
    exception.

    This patch fixes that by checking if port really exists and
    removing QoS bandwidth limit rules only for existing ports.

    Change-Id: I3775ee7b383ada6e4e4ace53b5405aa3c7c22027
    Closes-Bug: 1712913

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/500959

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/500959
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6b910965aacf420c1386abc24179dafc14031881
Submitter: Jenkins
Branch: stable/pike

commit 6b910965aacf420c1386abc24179dafc14031881
Author: Sławek Kapłoński <email address hidden>
Date: Mon Aug 28 20:59:12 2017 +0000

    Fix cleaning QoS rules for not existing port.

    If port update event is received by L2 agent and there is
    no QoS policy assigned to such port, agent tries to delete
    any existing QoS rules from port.
    For bandwidth limit rules OVS qos driver tries to update
    port in OVS database.
    In case if port not exists in OVS database agent raised
    exception.

    This patch fixes that by checking if port really exists and
    removing QoS bandwidth limit rules only for existing ports.

    Change-Id: I3775ee7b383ada6e4e4ace53b5405aa3c7c22027
    Closes-Bug: 1712913
    (cherry picked from commit 46289c3c74bfa6ce258067026b54fa9887e3a942)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.0.0b1 development milestone.