neutron

fwaas_v2: wrong parameter passed to FirewallGroupPortInvalidProject exception

Bug #1711127 reported by Inessa Vasilevskaya on 2017-08-16

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	Undecided	Inessa Vasilevskaya

Bug Description

Steps to reproduce: pike devstack, fwaas_v2

1. create a firewall group/policy/rule with project_id == devstack admin
2. try adding a router port with project_id == demo

This behavior will result in FirewallGroupPortInvalidProject exception which will never be raised properly because of wrong parameter 'tenant_id' passed to a constructor.

Tags:

Inessa Vasilevskaya (ivasilevskaya) on 2017-08-16

summary:	- wrong parameter passed to FirewallGroupPortInvalidProject exception + fwaas_v2: wrong parameter passed to FirewallGroupPortInvalidProject + exception
Changed in neutron:
assignee:	nobody → Inessa Vasilevskaya (ivasilevskaya)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-16: Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/494198

Changed in neutron:
status:	New → In Progress

Elena Ezhova (eezhova) on 2017-08-16

tags:

added: fwaas

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-29: Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/494198
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=c76e12cf64b23ffc543c8608eea2ff7468a5b42a
Submitter: Jenkins
Branch: master

commit c76e12cf64b23ffc543c8608eea2ff7468a5b42a
Author: Inessa Vasilevskaya <email address hidden>
Date: Wed Aug 16 12:48:35 2017 +0000

FirewallGroupPortInvalidProject can be raised now

    Earlier 'tenant_id' was passed instead of 'project_id'
    which resulted in AttributeError.
    This patch fixes the issue and also adds a covering unit test.

Change-Id: I64ce925537823644176753952d00c41b16c26924
Closes-Bug: #1711127

Changed in neutron:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-30: Fix proposed to neutron-fwaas (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/499038

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-06: Fix merged to neutron-fwaas (stable/pike)

Reviewed: https://review.openstack.org/499038
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=a7f901e8624876f290891c3d67daa0d0039a1d26
Submitter: Jenkins
Branch: stable/pike

commit a7f901e8624876f290891c3d67daa0d0039a1d26
Author: Inessa Vasilevskaya <email address hidden>
Date: Wed Aug 16 12:48:35 2017 +0000

FirewallGroupPortInvalidProject can be raised now

    Earlier 'tenant_id' was passed instead of 'project_id'
    which resulted in AttributeError.
    This patch fixes the issue and also adds a covering unit test.

    Change-Id: I64ce925537823644176753952d00c41b16c26924
    Closes-Bug: #1711127
    (cherry picked from commit c76e12cf64b23ffc543c8608eea2ff7468a5b42a)