ovsfw ignores icmp_{type,code}

[IWAMOTO Toshihiro]

The SG code uses port_range_{min,max} fields for ICMP type/code.
iptables_firewall handles that correctly but ovsfw lacks that knowledge, resulting in those fields ignored by the ovsfw driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/490346

[IWAMOTO Toshihiro (iwamoto)]

cf. https://bugs.launchpad.net/neutron/+bug/1582500
    https://review.openstack.org/#/c/427670

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/490346
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b82db0a9f24e16f426d9f693b7971bef4e080a7f
Submitter: Jenkins
Branch: master

commit b82db0a9f24e16f426d9f693b7971bef4e080a7f
Author: IWAMOTO Toshihiro <email address hidden>
Date: Thu Aug 3 15:36:33 2017 +0900

    ovsfw: Fix up port_range and ICMP type/code handling

    port_range_min/max should be read as ICMP type/code for ICMP(V6).

    Change-Id: I65157037038d11464902c0311eb4c54b84f60c72
    Closes-bug: #1708358

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501949

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501949
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=82e13a257c55cfe9c8de6b7cce3f1efce2c11695
Submitter: Jenkins
Branch: stable/pike

commit 82e13a257c55cfe9c8de6b7cce3f1efce2c11695
Author: IWAMOTO Toshihiro <email address hidden>
Date: Thu Aug 3 15:36:33 2017 +0900

    ovsfw: Fix up port_range and ICMP type/code handling

    port_range_min/max should be read as ICMP type/code for ICMP(V6).

    Change-Id: I65157037038d11464902c0311eb4c54b84f60c72
    Closes-bug: #1708358
    (cherry picked from commit b82db0a9f24e16f426d9f693b7971bef4e080a7f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.1 release.

[Zachary Ma (mazengxie)]

why port_range_min/max should be read as ICMP type ? ICMP protocol doesn't need port.

[IWAMOTO Toshihiro (iwamoto)]

Those port_range DB columns (or rpc parameters) should be interpreted as icmp type/code when protocol == icmp or icmpv6.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.0.0b1 development milestone.