insert_rule/remove_rule in policy.json should be moved to neutron-fwaas

Bug #1703347 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki

Bug Description

etc/policy.json in the neutron repo contains 'insert_rule' and 'remove_rule' which are specific to neutron-fwaas [1]. They should be moved to neutron-fwaas.

[1] https://github.com/openstack/neutron/blob/master/etc/policy.json#L121-L122

Tags: fwaas
Akihiro Motoki (amotoki)
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/482413

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/482414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/482414
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=355b250b101199873560e45529fe2db4cdb3a610
Submitter: Jenkins
Branch: master

commit 355b250b101199873560e45529fe2db4cdb3a610
Author: Akihiro Motoki <email address hidden>
Date: Mon Jul 10 20:02:40 2017 +0000

    Move remaining policy rules specific to neutron-fwaas

    There is no need to import the corresponding unit test
    in the neutron repo [1], as they just tests the policy engine
    is worked correctly.

    [1] https://github.com/openstack/neutron/blob/a51271d760b3a00f7648374d85fafb3d122a4985/neutron/tests/unit/test_policy.py#L273-L284

    Change-Id: I6dc6b2295a605444c918e44949f4b1485177e82e
    Partial-Bug: #1703347

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/482413
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a52f3af266e0443e26eaed248cde7ecdc6e37515
Submitter: Jenkins
Branch: master

commit a52f3af266e0443e26eaed248cde7ecdc6e37515
Author: Akihiro Motoki <email address hidden>
Date: Mon Jul 10 20:10:47 2017 +0000

    Remove neutron-fwaas specific policies

    Drops unit tests related to fwaas policies.

    Tests related to get_firewall_policy/rule are also unnecessary.
    They have been migrated to neutron-fwaas already.

    Closes-Bug: #1703347
    Depends-On: I6dc6b2295a605444c918e44949f4b1485177e82e
    Change-Id: Ie866f140fd4e5537ff0d757304ab5279f0cf0a79

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b3

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.