Trunk create fails due to case typo

[Bence Romsics]

When you boot a vm with a trunk using the ovs trunk driver the boot fails in allocating the network. While you get this ovs-agent error log:

neutron-openvswitch-agent[12170]: CallbackFailure: Callback neutron.services.trunk.drivers.openvswitch.agent.driver .OVSTrunkSkeleton.check_trunk_dependencies-1030432 failed with "no such option securitygroup in group [DEFAULT]"

The cause looks like to be a case typo in the fix of bug #1669074.

neutron/services/trunk/drivers/openvswitch/agent/driver.py:
wrong: cfg.CONF.securitygroup.firewall_driver
right: cfg.CONF.SECURITYGROUP.firewall_driver

[Bence Romsics (bence-romsics)]

Opened to cover this fix: https://review.openstack.org/475702

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/475702
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=012de2ea0875609c60445a731ead0b522e8cdb22
Submitter: Jenkins
Branch: master

commit 012de2ea0875609c60445a731ead0b522e8cdb22
Author: ZhaoBo <email address hidden>
Date: Tue Jun 20 16:31:09 2017 +0800

    Correct the config group in check_trunk_dependencies

    The 'securitygroup' is registered as cfg.CONF.SECURITYGROUP. Currently,
    this check always raise error as no 'cfg.CONF.securitygroup', then neutron
    will abort the trunk_create. So nova will error when create VM with trunk
    parent port for waiting timeout about the network-vif-plugged event.

    Closes-Bug: #1699516
    Related-Bug: #1669074
    Change-Id: I0b0bdb5a39f1978e12ddaeddd4e0d825894ea241

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/497924

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/497927

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/497927
Reason: Not consider release critical

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/497924
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6d0e5ba7f63783e2a6eded094ab14090fc704aa1
Submitter: Jenkins
Branch: stable/ocata

commit 6d0e5ba7f63783e2a6eded094ab14090fc704aa1
Author: ZhaoBo <email address hidden>
Date: Tue Jun 20 16:31:09 2017 +0800

    Correct the config group in check_trunk_dependencies

    The 'securitygroup' is registered as cfg.CONF.SECURITYGROUP. Currently,
    this check always raise error as no 'cfg.CONF.securitygroup', then neutron
    will abort the trunk_create. So nova will error when create VM with trunk
    parent port for waiting timeout about the network-vif-plugged event.

    Closes-Bug: #1699516
    Related-Bug: #1669074
    Change-Id: I0b0bdb5a39f1978e12ddaeddd4e0d825894ea241
    (cherry picked from commit 012de2ea0875609c60445a731ead0b522e8cdb22)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.4 release.