security group callbacks regression

Bug #1698812 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
Critical
YAMAMOTO Takashi
neutron
Fix Released
Undecided
YAMAMOTO Takashi

Bug Description

after_create callback gets empty security_group_rules.

eg. http://logs.openstack.org/87/199387/79/check/gate-tempest-dsvm-networking-midonet-ml2-ubuntu-xenial/331d691/logs/screen-q-svc.txt.gz

Jun 19 10:51:51.378599 ubuntu-xenial-rax-ord-9385124 neutron-server[10764]: DEBUG midonet.neutron.ml2.sg_callback [None req-d097915b-1336-4fb8-bcdc-cd49486aee54 admin admin] midonet.neutron.ml2.sg_callback.MidonetSecurityGroupsHandler method create_security_group called with arguments ('security_group', 'after_create', <neutron.plugins.ml2.plugin.Ml2Plugin object at 0x7f36b646aa10>) {'security_group': {'description': u'Default security group', 'tenant_id': u'1108c275750141b38d25d8fb05b19b82', 'created_at': '2017-06-19T10:51:51Z', 'updated_at': '2017-06-19T10:51:51Z', 'security_group_rules': [], 'revision_number': 5, 'project_id': u'1108c275750141b38d25d8fb05b19b82', 'id': '7e0bc780-7257-4506-a978-df7fb767bcc6', 'name': u'default'}, 'is_default': True, 'context': <neutron_lib.context.Context object at 0x7f36b42d44d0>} {{(pid=10854) wrapper /usr/local/lib/python2.7/dist-packages/oslo_log/helpers.py:47}}

Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

it seems I6f49f25eb2ad16221357024f45a6bb6175d5cd55 caused the regression.

tags: added: gate-failure midokura-jira-tracked
Changed in networking-midonet:
importance: Undecided → Critical
assignee: nobody → YAMAMOTO Takashi (yamamoto)
milestone: none → 5.0.0
status: New → In Progress
summary: - sg regression
+ security group callbacks regression
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/475445

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/475445
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=05293965f1aa2221649e8cebcdd318091c536af9
Submitter: Jenkins
Branch: master

commit 05293965f1aa2221649e8cebcdd318091c536af9
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Jun 20 00:40:58 2017 +0900

    Fix SG callbacks notification

    Fix a regression from the recent change. [1]

    [1] I6f49f25eb2ad16221357024f45a6bb6175d5cd55

    Closes-Bug: #1698812
    Change-Id: Ifef2561ef4ff2a44068fc008475b216fdabe7095

Changed in neutron:
status: In Progress → Fix Released
Changed in networking-midonet:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b3

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/512563

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/512563
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=445ce14ec1037d9df9f03c65b1fd38ef30c03d7b
Submitter: Zuul
Branch: master

commit 445ce14ec1037d9df9f03c65b1fd38ef30c03d7b
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Oct 17 18:33:14 2017 +0900

    _test_security_group_precommit_create_event: Check the result of create

    Related-Bug: #1724138
    Related-Bug: #1698812
    Change-Id: I31c07feb88b565970b9b97afacb7a53a5b28c137

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.