DVR FIP namespace missing default route after upgrade

[Kevin Benton]

After upgrading from a code without https://review.openstack.org/#/q/Ida165d1ecf5c07af31dac11d9daed33ccaaf5605,n,z to code with it, the FIP namespace default route gets removed but the rule based route does not get added so traffic destined to the addresses outside of the external network does not work.

The grenade job likely missed this because the test nodes have addresses directly on the external network so the default route isn't used.

[Kevin Benton (kevinbenton)]

Unless I am mistaken, this is going to break any upgrades to versions including https://review.openstack.org/#/q/Ida165d1ecf5c07af31dac11d9daed33ccaaf5605,n,z so I'm going to mark this as critical.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/475108

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/475110

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/475951

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/475110
Reason: master does not need this fix but stable branches do

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/475108
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4401777d5c923928209f26e23e5855207f653cc0
Submitter: Jenkins
Branch: stable/ocata

commit 4401777d5c923928209f26e23e5855207f653cc0
Author: Kevin Benton <email address hidden>
Date: Fri Jun 16 23:34:49 2017 -0700

    Always call create_rtr_2_fip_link

    Always call create_rtr_2_fip_link to ensure that the routes
    are setup even though the interface may already exist.

    This is necessary since Ida165d1ecf5c07af31dac11d9daed33ccaaf5605
    changed the routing setup to use rules instead of default routes
    and upgrading from an l3 agent before that change results in a
    FIP namespace without the routing rules setup.

    Conflicts:
          neutron/agent/l3/dvr_local_router.py

    Closes-Bug: #1698517
    Change-Id: I83d4b461fa4125c781227677ec9ed46704e832e9
    (cherry picked from commit a175e48248e4ab68a3fbf0d6e1c4f0fa449ce6ec)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/475951
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=25b1fe2aba11becf21702c9e6bba3c27ea03ed4a
Submitter: Jenkins
Branch: stable/newton

commit 25b1fe2aba11becf21702c9e6bba3c27ea03ed4a
Author: Kevin Benton <email address hidden>
Date: Fri Jun 16 23:34:49 2017 -0700

    Always call create_rtr_2_fip_link

    Always call create_rtr_2_fip_link to ensure that the routes
    are setup even though the interface may already exist.

    This is necessary since Ida165d1ecf5c07af31dac11d9daed33ccaaf5605
    changed the routing setup to use rules instead of default routes
    and upgrading from an l3 agent before that change results in a
    FIP namespace without the routing rules setup.

    Conflicts:
          neutron/agent/l3/dvr_local_router.py

    Closes-Bug: #1698517
    Change-Id: I83d4b461fa4125c781227677ec9ed46704e832e9
    (cherry picked from commit a175e48248e4ab68a3fbf0d6e1c4f0fa449ce6ec)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.3 release.