libffi-dev is missing in bindep.txt

[Akihiro Motoki]

When installing PyNaCL (required via paramiko by tempest) from tarball, libffi-dev is required. When a wheel package is not available, the installation fails.

http://logs.openstack.org/93/473393/1/check/gate-neutron-pep8-ubuntu-xenial/7c9aed9/console.html#_2017-06-13_00_45_02_298561

This also happens for cffi (required by oslo.privsep).

[Akihiro Motoki (amotoki)]

I checked if there are missing bindep entries other than libffi-dev, but it looks like libffi-dev is the only one.

I checked it in the following steps.

- Prepare Ubuntu 16.04 with minimum installation
- Create a new virtualenv
- pip install bindep
- sudo apt-get install `bindep -b -r bindep.txt test'
- sudo apt-get install libffi-dev
- pip install --no-binary :all: -r requirements.txt -r test-requirements.txt
(we can avoid using wheel packages by --no-binary :all: option)

[Ihar Hrachyshka (ihar-hrachyshka)]

This also breaks pep8 job.

[Ihar Hrachyshka (ihar-hrachyshka)]

Fix: https://review.openstack.org/#/c/473721/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/473721
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8e8f721f6ff615bf43f8563e8940e4d46388c0e7
Submitter: Jenkins
Branch: master

commit 8e8f721f6ff615bf43f8563e8940e4d46388c0e7
Author: Akihiro Motoki <email address hidden>
Date: Tue Jun 13 07:29:39 2017 +0000

    Add libffi-dev to bindep.txt

    libffi-dev is required to install cffi and PyNaCL from tarballs.
    cffi is installed from requirements.txt, so 'test' profile is not
    specified.

    We usual use wheel packages when installing python packages,
    but tarball is sometimes used, for example, when a new version
    is uploaded. I think it is worth adding it to bindep.txt
    to avoid accidental gate failure.

    Closes-Bug: #1697613
    Change-Id: I4800c9f213fa5c8f28c8603e022264e6aa139090

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.