neutron tag xxx.xxx doesn't work correctly

Bug #1694897 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zun
Invalid
Undecided
Unassigned
neutron
Fix Released
Low
Ihar Hrachyshka

Bug Description

Steps to reproduce:

  $ neutron tag-add --resource-type network --resource private --tag first.second
  $ neutron net-show private
  neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
  +-------------------------+--------------------------------------+
  | Field | Value |
  +-------------------------+--------------------------------------+
  ...
  | tags | first |
  ...
  +-------------------------+--------------------------------------+

The second half of the tag is not there.

hongbin (hongbin034)
Changed in zun:
status: New → Invalid
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

First step is, we block new neutronclient: https://review.openstack.org/469923

The plan is for Armando to look at potential server side fix. If not, we can revert the breaking change and release a new neutronclient with it: https://review.openstack.org/#/c/469746/

Changed in python-neutronclient:
importance: Undecided → Critical
status: New → In Progress
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Workaround for now would be to use anything other than a '.' as delimiter. The server freaks out when it sees one in tags.

Changed in python-neutronclient:
importance: Critical → Low
no longer affects: python-neutronclient
Changed in neutron:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/470016

Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/470016
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=527468be33407d65a940f1cd1e7a5a0bbbe12795
Submitter: Jenkins
Branch: master

commit 527468be33407d65a940f1cd1e7a5a0bbbe12795
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jun 1 21:08:20 2017 +0000

    api: work around Routes cutting off suffix from resource id

    Routes allows for auxiliary format suffix. Sadly it doesn't distinguish
    between an actual format suffix (.json) and any other suffix that may be
    part of the id. (like for first.second resource tag). To work this
    behavior around, we will reattach the 'format' suffix if it is not of a
    supported format (json only at the time of writing).

    This of course leaves a corner case where there is a tag where .json is
    a part of its id. This seems to be a reasonable balance to leave it
    unfixed, because an alternative would probably be not backwards
    compatible.

    Closes-Bug: #1694897
    Change-Id: I271107150166f0ee680faaa2e3ca6044cf4e8d4f

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/470330

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/470336

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/newton)

Reviewed: https://review.openstack.org/470336
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=48747eacdcf48574c284120f08ef8bc03bb9d252
Submitter: Jenkins
Branch: stable/newton

commit 48747eacdcf48574c284120f08ef8bc03bb9d252
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jun 1 21:08:20 2017 +0000

    api: work around Routes cutting off suffix from resource id

    Routes allows for auxiliary format suffix. Sadly it doesn't distinguish
    between an actual format suffix (.json) and any other suffix that may be
    part of the id. (like for first.second resource tag). To work this
    behavior around, we will reattach the 'format' suffix if it is not of a
    supported format (json only at the time of writing).

    This of course leaves a corner case where there is a tag where .json is
    a part of its id. This seems to be a reasonable balance to leave it
    unfixed, because an alternative would probably be not backwards
    compatible.

    Closes-Bug: #1694897
    Change-Id: I271107150166f0ee680faaa2e3ca6044cf4e8d4f
    (cherry picked from commit 527468be33407d65a940f1cd1e7a5a0bbbe12795)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/470330
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b50fed17fa338f4137646c9c8d8e47634b7f5ff7
Submitter: Jenkins
Branch: stable/ocata

commit b50fed17fa338f4137646c9c8d8e47634b7f5ff7
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jun 1 21:08:20 2017 +0000

    api: work around Routes cutting off suffix from resource id

    Routes allows for auxiliary format suffix. Sadly it doesn't distinguish
    between an actual format suffix (.json) and any other suffix that may be
    part of the id. (like for first.second resource tag). To work this
    behavior around, we will reattach the 'format' suffix if it is not of a
    supported format (json only at the time of writing).

    This of course leaves a corner case where there is a tag where .json is
    a part of its id. This seems to be a reasonable balance to leave it
    unfixed, because an alternative would probably be not backwards
    compatible.

    Closes-Bug: #1694897
    Change-Id: I271107150166f0ee680faaa2e3ca6044cf4e8d4f
    (cherry picked from commit 527468be33407d65a940f1cd1e7a5a0bbbe12795)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b2

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 9.4.1

This issue was fixed in the openstack/neutron 9.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.3

This issue was fixed in the openstack/neutron 10.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.