VPNaaS stuff should load inside of an l3 agent extension mechanism

[Kevin Benton]

It would be better if the VPNaaS agent stuff could be loaded just inside of the existing l3 agent rather than requiring operators to run a completely different binary with a subclass of the existing L3 agent. That way operators can just make a config change to enable/disable vpnaas.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/488247

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/501953

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/501978

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/511393

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/512473/ devstack

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/511393
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d7e93c52bff5fd0d25767620c838acbdfcc485f4
Submitter: Zuul
Branch: master

commit d7e93c52bff5fd0d25767620c838acbdfcc485f4
Author: Cao Xuan Hoang <email address hidden>
Date: Thu Oct 12 13:11:30 2017 +0700

    Add a new method ha_state_change to L3 agent extension

    This is needed by VPNaaS agent extension and other advanced
    services in case they support L3 HA router.

    Change-Id: Ice1b1c2ca97f47312e37379106ed5a6580f100dc
    Needed-By: I0b86c432e4b2210e5f2a73a7e3ba16d10467f0f2
    Related-Bug: #1692128

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501953
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b2a6b9087b64a7454985f14251cb0022adae70a5
Submitter: Zuul
Branch: master

commit b2a6b9087b64a7454985f14251cb0022adae70a5
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Sep 8 14:45:41 2017 +0900

    Add a new method get_router_info to L3 agent extension API

    This can be useful for VPNaaS agent extension. [1]

    [1] I0b86c432e4b2210e5f2a73a7e3ba16d10467f0f2

    Related-Bug: #1692128
    Change-Id: I5cfeb8db501b0cdba95c003ec6281c6a55a73b49

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/488247
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=99d2687b8313532512034e5b7d793fc16f9905a0
Submitter: Zuul
Branch: master

commit 99d2687b8313532512034e5b7d793fc16f9905a0
Author: Cao Xuan Hoang <email address hidden>
Date: Fri Jul 28 08:10:16 2017 +0700

    VPN as a Service (VPNaaS) Agent

    This is the iteration of the VPNaaS Agent with some basic
    functionality to enable integration of Plugin - Agent - Driver.

    Co-Authored-By: Van Hung Pham <email address hidden>
    Change-Id: I0b86c432e4b2210e5f2a73a7e3ba16d10467f0f2
    Closes-Bug: 1692128

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/501978
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.