eliminate SUBNET_GATEWAY callback resource

[Kevin Benton]

The gateway_ip of a subnet is not a separate resource and maintaining callbacks for it independently is a waste of effort. We should just ensure that SUBNET has the correct BEFORE and AFTER events for subscribers to check if the gateway changed and do whatever they need to based on that.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464773

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464774

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464108
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4489f34497d117009a77dbf73a3ff0eee44edf72
Submitter: Jenkins
Branch: master

commit 4489f34497d117009a77dbf73a3ff0eee44edf72
Author: Kevin Benton <email address hidden>
Date: Thu May 11 16:11:50 2017 -0700

    Move subnet event to db_base_plugin_v2

    There isn't anything ML2-specific about this event.
    It can just live in the same place as the SUBNET_GATEWAY event
    to prepare for the elimination of the SUBNET_GATEWAY event.

    Partial-Bug: #1690944
    Change-Id: If2c18c5d52658e90ebf1fe4bea91254c1bc5062f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464109
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=43ba3defbd72c53619d1b40fbbc7cdb438611a59
Submitter: Jenkins
Branch: master

commit 43ba3defbd72c53619d1b40fbbc7cdb438611a59
Author: Kevin Benton <email address hidden>
Date: Thu May 11 16:24:34 2017 -0700

    Get orig subnet in precommit method

    This small refactor will allow us to emit events
    in the subnet precommit handler containing the original
    subnet contents.

    Partial-Bug: #1690944
    Change-Id: I2105e0d805a8ce43c9b6d5bc429fa86e571926bf

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464110
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b23959b998f3d52793f4e07393b8ce1be8fb12aa
Submitter: Jenkins
Branch: master

commit b23959b998f3d52793f4e07393b8ce1be8fb12aa
Author: Kevin Benton <email address hidden>
Date: Thu May 11 16:24:57 2017 -0700

    Add BEFORE_UPDATE subnet event

    Adding a BEFORE_UPDATE event for the subnet will allow
    us to eliminate the BEFORE_UPDATE event for SUBNET_GATEWAY
    and eliminate the SUBNET_GATEWAY resource entirely.

    Partial-Bug: #1690944
    Change-Id: Id2d20bef43ff82f5698e826d391ce4480d729b27

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464773
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8f2aad8fe169e8d6c9663f808898b90e0b62aefd
Submitter: Jenkins
Branch: master

commit 8f2aad8fe169e8d6c9663f808898b90e0b62aefd
Author: Kevin Benton <email address hidden>
Date: Mon May 15 16:02:44 2017 -0700

    Use SUBNET instead of SUBNET_GATEWAY event in L3

    SUBNET_GATEWAY is being superceded by SUBNET, so
    we can just use that instead.

    Change-Id: I3ef5e6a046df4bae28aa111a796210a59df820fa
    Partial-Bug: #1690944

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464774
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7b239a928f7834ff98e0fff82491bfbb2a10eece
Submitter: Jenkins
Branch: master

commit 7b239a928f7834ff98e0fff82491bfbb2a10eece
Author: Kevin Benton <email address hidden>
Date: Mon May 15 15:54:35 2017 -0700

    Eliminate SUBNET_GATEWAY resource

    SUBNET_GATEWAY is not a real resource. It just corresponds to when
    an attribute of the SUBNET changes. We can just supercede it entirely
    by having everyone use the SUBNET resource, which solves significantly
    more use cases.

    Change-Id: Iae467bacb083888f72b8c9b52a10e4928a3ff6ab
    Closes-Bug: #1690944

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

[Ihar Hrachyshka (ihar-hrachyshka)]

Not a backport material.