neutron

Add missing unittests in segment db

Bug #1684519 reported by Dongcan Ye on 2017-04-20

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	Undecided	Dongcan Ye

Bug Description

Most of unit tests in segment db[1] are missing.
[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_segments_db.py

Tags:

Dongcan Ye (hellochosen) on 2017-04-20

Changed in neutron:
assignee:	nobody → Dongcan Ye (hellochosen)

Jakub Libosvar (libosvar) on 2017-04-21

tags:

added: low-hanging-fruit

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-05-04: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/462386

Changed in neutron:
status:	New → In Progress

Revision history for this message

Dongcan Ye (hellochosen) wrote on 2017-05-04:

Most test codes are located in [1], so we can add to there.
[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_db.py

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-10: Fix merged to neutron (master)

Reviewed: https://review.openstack.org/462386
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8595a017028450ba1c5f7cd0da4e6a9bd624666e
Submitter: Jenkins
Branch: master

commit 8595a017028450ba1c5f7cd0da4e6a9bd624666e
Author: Dongcan Ye <email address hidden>
Date: Thu May 4 14:02:05 2017 +0800

Add missing unit test for segment db

This patch add test for get_dynamic_segment.

Change-Id: Icf676059a0dd24ad18b8632563c4de81190f0d04
Closes-Bug: #1684519

Changed in neutron:
status:	In Progress → Fix Released

Ihar Hrachyshka (ihar-hrachyshka) on 2017-06-13

tags:	added: neutron-proactive-backport-potential
tags:	added: neutron-easy-proactive-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-14: Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/474267

Ihar Hrachyshka (ihar-hrachyshka) on 2017-06-14

tags:

removed: neutron-easy-proactive-backport-potential neutron-proactive-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-14: Fix proposed to neutron (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/474268

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-15: Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/474267
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fce4f77c5b3dd22a056b0913e785bacee3522c99
Submitter: Jenkins
Branch: stable/ocata

commit fce4f77c5b3dd22a056b0913e785bacee3522c99
Author: Dongcan Ye <email address hidden>
Date: Thu May 4 14:02:05 2017 +0800

Add missing unit test for segment db

This patch add test for get_dynamic_segment.

    Change-Id: Icf676059a0dd24ad18b8632563c4de81190f0d04
    Closes-Bug: #1684519
    (cherry picked from commit 8595a017028450ba1c5f7cd0da4e6a9bd624666e)

tags:

added: in-stable-ocata

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-17: Fix merged to neutron (stable/newton)

Reviewed: https://review.openstack.org/474268
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=00ac588968c62c5c47acee558a69142ca94505dc
Submitter: Jenkins
Branch: stable/newton

commit 00ac588968c62c5c47acee558a69142ca94505dc
Author: Dongcan Ye <email address hidden>
Date: Thu May 4 14:02:05 2017 +0800

Add missing unit test for segment db

This patch add test for get_dynamic_segment.

Newton changes: get_dynamic_segments receives session as the first
argument, not context.

    Change-Id: Icf676059a0dd24ad18b8632563c4de81190f0d04
    Closes-Bug: #1684519
    (cherry picked from commit 8595a017028450ba1c5f7cd0da4e6a9bd624666e)