tests should ensure expand scripts don't have non-nullable columns

Bug #1683514 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Low
Enyinna Ochulor

Bug Description

Currently our tests don't prevent us from adding a non-nullable column without a server default. This will prevent older versions of the server from inserting records into the table so we can't let these merge.

It would be good if we had a test in our migration validation logic that ensures that any added columns are either nullable or they define a server-default.

tags: added: db
Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
tags: added: low-hanging-fruit
Changed in neutron:
assignee: nobody → Enyinna Ochulor (enyinna1234)
Revision history for this message
Enyinna Ochulor (enyinna1234) wrote :

I'm new to neutron. I want to use this as part of my introduction to neutron development. I've been going over this. Do you know what the possible workflow should be to achieve this? It looks like this can be accomplished by making changes to neutron/neutron/tests/functional/db/test_migrations.py?

Revision history for this message
Sapna Jadhav (sapana45) wrote :

Hi, is this issue still exist?

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Bug closed due to lack of activity, please feel free to reopen if needed.

Changed in neutron:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.