overwriting oslo.db defaults

[Joe Talerico]

oslo.db sets the max_overflow to 50 by default, however Neutron common/config.py overwrites that with 20.

Version: Ocata

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/456419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/456419
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=27d18ac5c5205604243ef50305e1ba40979551ca
Submitter: Jenkins
Branch: master

commit 27d18ac5c5205604243ef50305e1ba40979551ca
Author: Joe Talerico <email address hidden>
Date: Wed Apr 12 20:14:59 2017 -0400

    Don't override default values for oslo.db options

    This change will make neutron-server use default values from oslo.db if
    any of them are not overridden in config files, instead of applying its
    own unique values that may be unexpected to users and operators.

    It also makes our config files correct since now we don't claim wrong
    values being default. (Remember the config generator was never aware of
    our snowflake behaviour.)

    If you wonder why we were overriding it in the first place, it was
    needed back in the times when we were using db module from
    oslo-incubator that has not provided proper defaults. Those times are
    long gone.

    Of course the change is not impact free, and operators who for some
    reason want to keep the old values may need to adjust their
    configuration files. Still, I believe using default values from oslo.db
    is the correct thing to do long term.

    We still need to set connection string for unit tests to sqlite:// since
    oslo.db doesn't provide any default value for the option. It should be
    fine to effectively unset default value for the option for
    neutron-server since no one in production can use sqlite anyway.

    This change also drops set_db_defaults function from
    neutron.common.config. I have checked that there are no consumers for
    the function outside the tree.

    NeutronLibImpact
    UpgradeImpact

    Co-Authored-By: Ihar Hrachyshka <email address hidden>
    Change-Id: Ia97d6cf24e554f7b3878dd301ae4e7e10a1c9998
    Closes-Bug: #1682307

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

[Ihar Hrachyshka (ihar-hrachyshka)]

Not a backport material.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/481646

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/481646

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/536951

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536951
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=170e1764c4682c0bcf15deb3e83bb51e7735e2c4
Submitter: Zuul
Branch: master

commit 170e1764c4682c0bcf15deb3e83bb51e7735e2c4
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Jan 23 12:09:32 2018 -0800

    Don't override oslo.db tweaks for connection pool in tests

    This is in a way a follow-up for
    Ia97d6cf24e554f7b3878dd301ae4e7e10a1c9998 that removed the same in
    production neutron code to rely on default values inherited from
    oslo.db. There is no clear need to override those settings in test
    environment either, so at best it's boilerplate code.

    Related-Bug: #1682307
    Change-Id: Ie2e2dd0659b1cd6d8b8480e2d78d00475ab01b40