neutron

QoS policy object can't be suitable with 1.2 version of object

Bug #1681440 reported by Slawek Kaplonski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Slawek Kaplonski

Bug Description

In https://github.com/openstack/neutron/blob/master/neutron/objects/qos/policy.py#L220 there is no function to make QoS policy object compatible with version 1.2 and higher (append QoSMinimumBandwidthLimit rules to policy)

Slawek Kaplonski (slaweq)
Changed in neutron:
assignee: nobody → Slawek Kaplonski (slaweq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/455338

Changed in neutron:
status: New → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

This would be a problem for L to M migration only. And since Mitaka is about to EOL, I don't think we should really pursue a fix here. If anything, we may instead clean up some rules.

Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
status: In Progress → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/455338
Reason: it's not needed anymore

OpenStack Infra (hudson-openstack)
Changed in neutron:
status: Won't Fix → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/455338
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0376d2f6adada320554f247e4c67e15243d01d74
Submitter: Jenkins
Branch: master

commit 0376d2f6adada320554f247e4c67e15243d01d74
Author: Sławek Kapłoński <email address hidden>
Date: Mon Apr 10 14:09:51 2017 +0000

    Make QoS policy object compatible with versions 1.2 and higher

    For version 1.2 or higher of QoS policy object it can contain
    QoSMinumumBandwidtLimit rules and appending of such rule type
    was missing in make_obj_compatible function.
    Now such rules are appended to QoS policy.

    Change-Id: I40d699db58c34e83272432376d1d59679a680db2
    Closes-Bug: #1681440

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b2

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

Ihar Hrachyshka (ihar-hrachyshka)
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/474061

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/474061
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d051062019f1058a75d6067d81a9f2d658484529
Submitter: Jenkins
Branch: stable/ocata

commit d051062019f1058a75d6067d81a9f2d658484529
Author: Sławek Kapłoński <email address hidden>
Date: Mon Apr 10 14:09:51 2017 +0000

    Make QoS policy object compatible with versions 1.2 and higher

    For version 1.2 or higher of QoS policy object it can contain
    QoSMinumumBandwidtLimit rules and appending of such rule type
    was missing in make_obj_compatible function.
    Now such rules are appended to QoS policy.

    Change-Id: I40d699db58c34e83272432376d1d59679a680db2
    Closes-Bug: #1681440
    (cherry picked from commit 0376d2f6adada320554f247e4c67e15243d01d74)

tags: added: in-stable-ocata
Daniel Alvarez (dalvarezs)
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.3

This issue was fixed in the openstack/neutron 10.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.