vpnaas endpoint related UT failure

[YAMAMOTO Takashi]

eg.
http://logs.openstack.org/14/445114/10/check/gate-neutron-vpnaas-python27-ubuntu-xenial/c87f6d6/testr_results.html.gz

ft2.11: neutron_vpnaas.tests.unit.db.vpn.test_vpn_db.TestVpnaas.test_create_ipsec_site_connection_StringException: Empty attachments:
  stdout

pythonlogging:'': {{{ERROR [neutron.api.extensions] Extension path 'neutron/tests/unit/extensions' doesn't exist!}}}
stderr: {{{
/home/jenkins/workspace/gate-neutron-vpnaas-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py:22: DeprecationWarning: Parameters to load are deprecated. Call .resolve and .require separately.
  return pkg_resources.EntryPoint.parse("x=" + s).load(False)
}}}

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-neutron-vpnaas-python27-ubuntu-xenial/.tmp/tmp.Q1k56Jlxhb/openstack/neutron/neutron/tests/base.py", line 116, in func
    return f(self, *args, **kwargs)
  File "neutron_vpnaas/tests/unit/db/vpn/test_vpn_db.py", line 1214, in test_create_ipsec_site_connection
    self._test_create_ipsec_site_connection(key_overrides=extras)
  File "neutron_vpnaas/tests/unit/db/vpn/test_vpn_db.py", line 1207, in _test_create_ipsec_site_connection
    dpd)
  File "neutron_vpnaas/tests/unit/db/vpn/test_vpn_db.py", line 410, in _check_ipsec_site_connection
    in ipsec_site_connection.items()
  File "/home/jenkins/workspace/gate-neutron-vpnaas-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/jenkins/workspace/gate-neutron-vpnaas-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = {'admin_state_up': True,
 'description': 'my-ipsec-connection',
 'ikepolicy_id': u'c63f4e69-420b-4cba-9bc6-77dde7e22fd7',
 'initiator': 'bi-directional',
 'ipsecpolicy_id': u'57074a7b-a9b3-4735-969c-e1ed0a0e3b92',
 'mtu': 1500,
 'name': 'connection1',
 'peer_address': '192.168.1.10',
 'peer_cidrs': ['192.168.2.0/24', '192.168.3.0/24'],
 'peer_id': '192.168.1.10',
 'psk': 'abcd',
 'status': 'PENDING_CREATE',
 'tenant_id': '46f70361-ba71-4bd0-9769-3573fd227c4b',
 'vpnservice_id': u'ac1c2e78-96a0-4f3b-a640-b92820675754'}
actual = {u'admin_state_up': True,
 u'description': u'my-ipsec-connection',
 u'ikepolicy_id': u'c63f4e69-420b-4cba-9bc6-77dde7e22fd7',
 u'initiator': u'bi-directional',
 u'ipsecpolicy_id': u'57074a7b-a9b3-4735-969c-e1ed0a0e3b92',
 u'mtu': 1500,
 u'name': u'connection1',
 u'peer_address': u'192.168.1.10',
 u'peer_cidrs': [],
 u'peer_id': u'192.168.1.10',
 u'psk': u'abcd',
 u'status': u'PENDING_CREATE',
 u'tenant_id': u'46f70361-ba71-4bd0-9769-3573fd227c4b',
 u'vpnservice_id': u'ac1c2e78-96a0-4f3b-a640-b92820675754'}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/452691

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452691
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9a0907dbb9eaf1dcf7f1ccfc22b0e6e4f775b046
Submitter: Jenkins
Branch: master

commit 9a0907dbb9eaf1dcf7f1ccfc22b0e6e4f775b046
Author: YAMAMOTO Takashi <email address hidden>
Date: Mon Apr 3 19:31:32 2017 +0900

    Flush objects by ourselves before processing before_commit event

    During commit processing, sqla automatically flushes objects.
    However, it does so after dispatching the before_commit event,
    while Neutron expects it happens before the event. This
    counter-intuitive behaviour might or might not be considered
    a bug in sqla. Anyway, it's better to be safe in our side.

    Closes-Bug: #1678726
    Change-Id: Iceaf178be2885b0299d6d281983e9f7f8ae6def0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.