eliminate callbacks for EXTERNAL_NETWORK

Bug #1678041 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Kevin Benton

Bug Description

EXTERNAL_NETWORK is not a real resource. It's just a network with a specific attribute so having an independent callback is not necessary, nor do the semantics make sense (e.g. a network changing from external to non-external is a DELETE or an UPDATE?).

We should be able to get by with just NETWORK events.

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
importance: Undecided → Wishlist
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/453035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/453036

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/453035
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5e125c92197031bf84be7a02c7eab02a8578adf7
Submitter: Jenkins
Branch: master

commit 5e125c92197031bf84be7a02c7eab02a8578adf7
Author: Kevin Benton <email address hidden>
Date: Tue Apr 4 00:03:06 2017 -0700

    Add net precommit create callback and req to update

    This adds a network precommit create callback to ML2
    and adjusts the precommit update callback to include
    the request.

    This changes will be leveraged by the dependendent
    patch Id2db458f4688e4aa4c70ccdb09867b9a66de28ea.

    Partial-Bug: #1678041
    Change-Id: Ic99955356e564354e6dbeb4d46497e4d64e4656c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/440344
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=59589929e59f4b8c147bd90240ae6fabeb2671ac
Submitter: Jenkins
Branch: master

commit 59589929e59f4b8c147bd90240ae6fabeb2671ac
Author: Kevin Benton <email address hidden>
Date: Thu Mar 2 02:59:52 2017 -0800

    Use NETWORK callbacks in get-me-a-network code

    This adjusts the get-me-a-network code to just
    rely on the regular NETWORK precommit events rather
    than the EXTERNAL_NETWORK events that the following
    patch eliminates.

    Partial-Bug: #1678041
    Change-Id: Id2db458f4688e4aa4c70ccdb09867b9a66de28ea

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/453036
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cc59e9f159ace557a61586e1df3f4d0b6054ed2f
Submitter: Jenkins
Branch: master

commit cc59e9f159ace557a61586e1df3f4d0b6054ed2f
Author: Kevin Benton <email address hidden>
Date: Tue Apr 4 00:06:52 2017 -0700

    Remove EXTERNAL_NETWORK callbacks

    external networks are not really independent resources that
    have their own lifecycles independent from networks. The only
    use cases for this callback can be achieved with just regular
    NETWORK callbacks.

    The only users of this event have been adjusted to use NETWORK
    callbacks (according to codesearch.openstack.org).

    Closes-Bug: #1678041
    Change-Id: Ie8249ddc3de643bfcb5c97480f30dc3500699256

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b2

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.