"Skip DHCP agent query in provisioning block setup" requires DHCP wiring acknowledgement

Bug #1677729 reported by Thomas Morin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BaGPipe
Fix Released
High
Unassigned
neutron
Fix Released
High
Kevin Benton

Bug Description

bissecting leads me to conclude that networking-bagpipe unit tests have been broken (see e.g. [0]) by [1] which is the merge commit for https://review.openstack.org/#/c/440340/

I haven't digged, but the reason is not obviously identifiable (well, by me at least)

[0] http://logs.openstack.org/periodic/periodic-networking-bagpipe-py35-with-neutron-lib-master/36c4ad1/testr_results.html.gz
[1] http://git.openstack.org/cgit/openstack/neutron/commit/?id=dc84e891ca4aa13e35d841d12ae791271e39b1e3
[2] https://review.openstack.org/#/c/440340/

Tags: fullstack
no longer affects: bgpvpn
Changed in networking-bagpipe:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Thomas Morin (tmmorin-orange) wrote : Re: some tests failing after merge of "Skip DHCP agent query in provisioning block setup"

The cause is explained in https://review.openstack.org/#/c/451699/ (unmerged yet revert of the problematic change) and https://review.openstack.org/#/c/451704/ (tentative solution).

summary: - test failing in n8g-bagpipe after merge of "Skip DHCP agent query in
- provisioning block setup"
+ some tests failing after merge of "Skip DHCP agent query in provisioning
+ block setup"
Revision history for this message
Kevin Benton (kevinbenton) wrote :

This is impacting the fullstack tests as well.

tags: added: fullstack
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bagpipe (master)

Reviewed: https://review.openstack.org/451983
Committed: https://git.openstack.org/cgit/openstack/networking-bagpipe/commit/?id=498cf8caf0180d1146d55f0f35c01e8cd89446dc
Submitter: Jenkins
Branch: master

commit 498cf8caf0180d1146d55f0f35c01e8cd89446dc
Author: Thomas Morin <email address hidden>
Date: Thu Mar 30 15:57:24 2017 -0500

    bagpipe ml2: don't wait for DHCP provisioning block to clear

    Adapt our unit test like the l2pop unit test are adapted
    in I8111469ad4b0d88580bff7a77492ad95af8e9377 .

    Needed or else ports never go ACTIVE.

    Change-Id: I53f7a1617ed578b58a8332a3d35b4527692851a2
    Closes-Bug: 1677729

Changed in networking-bagpipe:
status: Confirmed → Fix Released
Revision history for this message
Brian Haley (brian-haley) wrote : Re: some tests failing after merge of "Skip DHCP agent query in provisioning block setup"

Is there still any neutron work that needs to be done here or can that part of the bug be closed-out?

Changed in neutron:
assignee: nobody → Jakub Libosvar (libosvar)
summary: - some tests failing after merge of "Skip DHCP agent query in provisioning
- block setup"
+ "Skip DHCP agent query in provisioning block setup" requires DHCP wiring
+ acknowledgement
Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → High
Changed in neutron:
assignee: Jakub Libosvar (libosvar) → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-bagpipe 7.0.0.0b1

This issue was fixed in the openstack/networking-bagpipe 7.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/451704
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2448df86516c2a4246eed9cd4e59a2d75e4d96e0
Submitter: Jenkins
Branch: master

commit 2448df86516c2a4246eed9cd4e59a2d75e4d96e0
Author: Kevin Benton <email address hidden>
Date: Thu Mar 30 01:50:51 2017 -0700

    Fullstack: enable DHCP agent

    With the merge of I8111469ad4b0d88580bff7a77492ad95af8e9377,
    ports will not transition to the ACTIVE status on a subnet
    that has DHCP enabled that does not clear the DHCP provisioning
    block. So if we don't deploy a DHCP agent for these tests,
    the ports will not transition to ACTIVE.

    This fixes the fullstack tests by adding DHCP agents
    to clear the provisioning block.

    Co-Authored-By: Jakub Libosvar <email address hidden>
    Closes-bug: #1677729
    Change-Id: I66c5e4ead23f0e6bd4b9e867c8cf419f67f6d78c

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b2

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.